MediaWiki talk:RefToolbarNoDialogs.js

Use of "$j" is deprecated. Use $ or jQuery instead

See also: MediaWiki talk:Gadget-refToolbarBase.js § Use of "$j" is deprecated. Use $ or jQuery instead

Could someone please replace the depracated "$j" by "$" and simplify those "new Array()" to just "[]"? Helder.wiki 16:20, 21 March 2014 (UTC)

done —TheDJ (talk • contribs) 06:05, 24 March 2014 (UTC)

Bugfix for caret focus

On line 294, change:

  insertTags(cite, '', '');

to:

  $("#wpTextbox1").focus();
  insertTags(cite, '', '');

On line 362, change:

  insertTags(ref, '', '');

to:

  $("#wpTextbox1").focus();
  insertTags(ref, '', '');

This fixes an annoying bug with RefToolbar where the citation text gets inserted in the wrong edit field. This fix simply forces the input focus to the main wikitext edit field right before the insertion, which is the expected behaviour of the "Insert citation" tool. See RefToolbar talk. hydrox (talk) 14:38, 3 April 2014 (UTC)

Also, similar edits need to be done for MediaWiki:RefToolbarLegacy.js. --hydrox (talk) 15:50, 3 April 2014 (UTC)

Not done: please establish a consensus for this alteration before using the {{edit protected}} template. I object. I've used the RefToolbar to intentionally insert stuff into the edit summary and this would prevent that (well, it would add an extra step of me having to add it to the edit box and then cut and paste). — {{U|Technical 13}} ^{(t • e • c)} 16:28, 3 April 2014 (UTC)

Are you serious? This is just a non-controversial edit that fixes an error within the software. But I can understand if you think someone who can understand the code change should do a code review, but I don't think there is a consensus required. I am resetting the request to unanswered pending someone to just review the code change. It only fixes a bug, after all. Please see my last comment here for a thorough explanation of what is the problem. --hydrox (talk) 16:48, 3 April 2014 (UTC)

Taken on trust and Done --Redrose64 (talk) 17:35, 3 April 2014 (UTC)

Thanks --hydrox (talk) 17:43, 3 April 2014 (UTC)

Bug fix

Please change the line (about 20 lines down)

      $('#reftoolbar-button').live('click', function() { easyCiteMain(); });

to

      $(document).on('click', '#reftoolbar-button', function() { easyCiteMain(); });

This is because the live() function has been removed, and no longer works. Thanks, — This, that and the other (talk) 05:03, 31 December 2014 (UTC)

Done — Mr. Stradivarius ^{♪ talk ♪} 06:26, 31 December 2014 (UTC)

Protected edit request on 8 October 2015

At lvwiki (we're using the same version of code as enwiki) I get such error: TypeError: document.getElementById(...).childNodes[0].childNodes[1] is undefined. I'm almost sure that it is related to this script. OK, it doesn't break the Reftoolbar here, but I suppose it would be good to fix it. Or at least tell me, what I should change @lvwiki :) --Edgars2007 (talk/contribs) 06:52, 8 October 2015 (UTC)

@Edgars2007: Could you include the full error message, especially the part inside getElementById(). That will help track it down. Kaldari (talk) 16:29, 8 October 2015 (UTC)

I tried it out on lvwiki and it seems to work fine. Are you still seeing the error? Kaldari (talk) 17:09, 8 October 2015 (UTC)

And there is probably a typo in the code. At function citeJournal() there is <legend>Cite book source</legend>, but there should be <legend>Cite journal source</legend>. --Edgars2007 (talk/contribs) 07:06, 8 October 2015 (UTC)

Maybe try asking the scripts creator Kaldari, or post at WP:VPT. — Martin (MSGJ · talk) 10:13, 8 October 2015 (UTC)

 Done Kaldari (talk) 16:42, 8 October 2015 (UTC)