MediaWiki talk:Common.js/Archive 10

"Navframe" boxes no longer collapsing
I'm not sure what changes were made, but boxes no longer collapse automatically if there are more than two on a page - and there is no longer any spacing between them. Please see the bottom of the Paris article for an example. I'm using Safari on Mac os X 10.4.10 (intel). Cheers. THE PROMENADER  07:58, 27 August 2007 (UTC)


 * I am semi-responsible for this, but, those need to be navboxes. I'll try to convert them.  shudder! &larr;BenB4 18:32, 31 August 2007 (UTC)

code on diff pages
See this diff. Why isn't the code at the bottom properly handled, causing the message to appear at the top of the page? —Ruud 16:39, 28 August 2007 (UTC)
 * No idea, but it's only on diffs on MediaWiki:Common.js. — M ETS 501 (talk) 16:41, 28 August 2007 (UTC)
 * Because on diffs the content for .js/.css pages is not made "safe". This particular case could be fixed e.g. by using . Btw, I would really recommend nice and easy-on-the-server option "Don't show page content below diffs" ∴ Alex Smotrov 17:06, 28 August 2007 (UTC)
 * Yeah, but the is interpreted as wikitext. Yes, another way to avoid this would be using &lt;pre> Mediawiki tag (which is not the same as HTML &lt;pre> tag). I'm not sure what you mean about  in http://en.wikipedia.org/skins-1.5/common/wikibits.js?97 and I have no idea why logging out would make any difference.  Someone should post this on WP:VPT.  I guess I will just did. &larr;Ben B4  11:23, 4 September 2007 (UTC)


 * This was caused by the innerHTML rewriting code that mets put in with one of his changes. It looks like rewriting innerHTML causes pre-existing handles to dom objects inside to get invalidated. I confirmed that was the cause, and it's been removed. The message should be installed without rewriting the bodycontent div entirely. Until a fixed version has been tested the rotating lower notice should stay out. (upper notice isn't an issue) --Gmaxwell 14:03, 4 September 2007 (UTC)
 * Much less sucky, and much improved article appearance. Constructive suggestion: instead of re-instating the (imo unimportant) spam on top of the article title, merge those messages into the rotating ones about funding. I suppose there is a desire somewhere to have more money messages than non-money messages, so wrap the random number selection up inside another one. The outer selection can be weighted as desired to indicate from which subset the message should be chosen; the message itself is selected from that subset by the existing random selection. Splash - tk 15:12, 4 September 2007 (UTC)
 * To be clear, the article-title spam has been re-instated since I last got a cached page (there was no anonnotice spam briefly) which is mistaken and bad, and the Internet now sucks the more for it. At least it no longer stomps all over the actual content, though. Splash - tk 15:17, 4 September 2007 (UTC)


 * On the subject of your 'constructive suggestions' ... if we were playing scrabble you would currently be suffering from a tremendous deficit of the letter s, p, a, and m. :) You can only call something crap that others think is a good idea so many times before your opinion starts to lose its weight. We are already abundantly aware that you think things like that donation notice are "spam", "advertisements", and any number of other nasty sounding things which are, no doubt, just the first step to completely selling out to Google or something like that....  It stopped being constructive about the 4th time you said it in the last two days. --Gmaxwell 15:34, 4 September 2007 (UTC)
 * ...and the *notice.js probably stopped being effective after the 4th time that the readers came across them for similar reasons. Though, I am at a loss to explain how you extrapolated to selling out to Google. Splash - tk 15:49, 4 September 2007 (UTC)


 * I evaluated setting a cookie when a user sees or clicks a notice to prevent them from seeing another notice for a span of time, but we can't currently do this because even if the site itself will do nothing with the cookie as soon as it is set our squids will no longer cache the pages. If this happened with anons the site would instantly go hard-down. Once we can figure out how to do persistent client side storage that doesn't defeat caching we'll make these a little more smart.
 * The donation notices do, however, have a huge impact on our income. ... and the Wikipedia educational material is important because there is constant misunderstanding of Wikipedia, the press is never going to get it right, and if we don't take some action we and the public will continue to suffer because of it.
 * As far as the extrapolation goes, I was being a little mean.. Sorry. But it really isn't nice or fair to call the notices "spam", "advertisements", or "making the Internet suck".
 * Your commentary on the technical points, and raising the issue of the anonnotice hitting the title after it was removed from the commonjs the first time has been very helpful and I'm sure it is appreciated by all. But to me it seems your approach with the philosophical issue of reader targeted messages is very negative and largely built on loaded language rather than things we can discuss and come to agreement on. --Gmaxwell 16:54, 4 September 2007 (UTC)

Well the diff buttons are fixed, but why would rewrting innerHTML invalidate logged-out users' handles but not logged in users'? &larr;Ben B4 18:35, 4 September 2007 (UTC)
 * The code in question only runs for logged out users, so nothing happens when you're logged in. Tra (Talk) 18:59, 4 September 2007 (UTC)

The reinstatement of this still clashed with article titles. It is to my mind completely unacceptable that it do so. The main difference between and  appears to be the top:3px and font-size:100%, and so I've changed them to be the same as in mediawiki:anonnotice ie top:0px and font-size:80%. This has the effect of making the text look rather small, not sure why. But at least it no longer disrupts the title line(s).

Incidentally, why must there be so much formatting in these messages? There black, blue, grey, bold, italics, bullets and punctuation. dewiki just uses plain text and a link. Is that not enough? Splash - tk 12:27, 5 September 2007 (UTC)


 * Everyone knows that Germans are staid and colorless. C e l e b r a t e t h e c o l o r o f t h e E n g l i s h l a n g u a g e ! ! ! 1 ! &larr;Ben B4  22:16, 5 September 2007 (UTC)

Internet Explorer fix for PNG transparency
I've got a script together that should fix most of the PNG transparency issues in Internet Explorer 6. Comments would we welcome at Village pump (technical). —Remember the dot (talk) 02:48, 8 September 2007 (UTC)

Edokter has just confirmed at the main discussion thread that this script works without problems. I have extensively tested the script myself and now request that it be added to common.js. The code to add is given at Village pump (technical). —Remember the dot (talk) 23:14, 8 September 2007 (UTC)
 * [[Image:Yes check.svg|20px]] Done. Cheers. --MZMcBride 00:12, 9 September 2007 (UTC)

should be replaced with  (the former is specific to IE, but it's best to synchronize everything with the latter). I'm not too fond of innerHTML either, but if the script works, it works... Grace notes T § 01:08, 9 September 2007 (UTC)


 * Feel free to tweak it however you like, so long as you're sure it won't break anything. —Remember the dot (talk) 01:16, 9 September 2007 (UTC)


 * Here:
 * Per Gracenotes's suggestion please change  to  . —Remember the dot (talk) 01:23, 9 September 2007 (UTC)
 * Per Gracenotes's suggestion please change  to  . —Remember the dot (talk) 01:23, 9 September 2007 (UTC)


 * [[Image:Yes check.svg|20px]] Done. Cheers. --MZMcBride 02:53, 9 September 2007 (UTC)

For IE in some cases window. addOnloadHook is not the same as onload event, so that change should have been tested first. Also, how about asking the devs to move the code into IEFixes.js instead? ∴ Alex Smotrov 03:19, 9 September 2007 (UTC)


 * Yes, addOnloadHook is built into MediaWiki. (Not a function of the window object.) I think it's better to keep modifications of the DOM synchronous, hence addOnloadHook. Re IEFixes.js: that sounds like a good idea, although the function already exists as fixalpha. Perhaps it doesn't work? :| Grace notes T § 04:25, 9 September 2007 (UTC)


 * It appears to me that IEfixes.js only fixes the transparency on the Wikipedia logo. If someone would like to file a bug asking the developers to apply the fix to all images, by all means go right ahead. —Remember the dot (talk) 04:47, 9 September 2007 (UTC)


 * The devs might not have implemented it because they didn't know how to make the code work quite right for all images. I had to tweak pngfix.js to specify "vertical-align:middle" or else it would mess up the layout in some cases. Maybe the devs tried but didn't figure out that they needed to set that one property. In any case, filing a bug (feature request, really) would probably be a good idea. —Remember the dot (talk) 04:57, 9 September 2007 (UTC)

I loaded IE6 to test the fix, and I found that some images (such as those used in Template:Proposed and Template:Historical) now appear vertically stretched (on my end, at least). Is anyone else seeing this? —David Levy 08:27, 9 September 2007 (UTC)


 * That looks like another Internet Explorer quirk. I fixed it by removing the font-size CSS parameter on the image's table cell. The parameter was only in there for text-only browsers (of which there are few), so it's no big loss. But you can avoid the problem entirely by just not using old versions of IE. —Remember the dot (talk) 19:34, 9 September 2007 (UTC)


 * Thanks for identifying and resolving the problem. I use Firefox, but I try to make sure that things are working as well as possible for people running older IE versions.
 * What sort of effect will this change have on users of text-only browsers? —David Levy 00:43, 10 September 2007 (UTC)

Bugfix
A bug has been identified which causes borders to fail to display in IE 5.5 and 6. I believe that changing the code to make images into divs instead of spans will resolve this. So, please change the PngFix function to read:

—Remember the dot (talk) 00:09, 10 September 2007 (UTC)

Never mind - changing it to a div would probably break more things than it fixes. Instead, try changing  to   —Remember the dot (talk) 00:31, 10 September 2007 (UTC)


 * Changing the  has fixed the distortion on some flags, but the border problem persists.  Interestingly, flag icons that are still based on jpg images do show the grey border.  It's just PNG and SVG that do not.  Andrwsc 00:38, 10 September 2007 (UTC)


 * OK, then try switching from using spans to using divs. This isn't standards-compliant, but Internet Explorer doesn't seem to care (surprise, surprise). For reference, the code would be:
 * OK, then try switching from using spans to using divs. This isn't standards-compliant, but Internet Explorer doesn't seem to care (surprise, surprise). For reference, the code would be:

—Remember the dot (talk) 00:48, 10 September 2007 (UTC)


 * Has this code been tested? --MZMcBride 00:55, 10 September 2007 (UTC)


 * Unfortunately, no. I'll go try and test it... —Remember the dot (talk) 01:03, 10 September 2007 (UTC)

Tada!
OK, I've found a fix (and tested it in my userpace on the Commons), but you'll have to edit two files. Change the pngfix code to read:

Then hop over to Mediawiki:Common.css and add the following:

In the future, the Mediawiki software may do all this automatically. But as for right now, we have to work with what we've got.

For the technically minded, I moved all the CSS styling information to a span outside the image, and made the image's span separate. I had to set the font-size property of the outer span to 0 in order to make it shrink-wrap the inner span. —Remember the dot (talk) 03:34, 10 September 2007 (UTC)
 * [[Image:Yes check.svg|20px]] Done. Cheers. --MZMcBride 04:28, 10 September 2007 (UTC)

addOnloadHook is not specifically a function of the window object, so that might need to be altered. I do realize philosophy differs on this, but it might be a good idea to have some discussion of an editprotected request before it's implemented. But, again, this is a wiki. Things are reversible. Grace notes T § 06:16, 10 September 2007 (UTC)


 * I will attemt to clean up the code a bit, because I already discovered a double 'style=' and a 'display:inline-block' declaration within the same span, which is just awfull coding. I will conduct some tests myself to find out which fix really fixed the border; maybe simply adding the .thumborder would have sufficed. Will report back later. — Edokter  •  Talk  • 13:46, 10 September 2007 (UTC)


 * I see another problem now too. The alt attribute is truncated if it has a single quote character, as in the case of  (🇨🇳 - should be Flag of the People's Republic of China) and  🇨🇮).  Andrwsc 16:02, 10 September 2007 (UTC)


 * That should be easy to fix, but I don't have time to work on it right now. —Remember the dot (talk) 16:21, 10 September 2007 (UTC)

I'm surprised it even WORKS! I see so many syntax errors in the code above (" and ' mixed, missing "px" in width and height parameters, etc.), but when I test my cleaned up code, the image diappears! This is maddening... — Edokter  •  Talk  • 19:46, 10 September 2007 (UTC)


 * Again, I'll work on it when I can. I'll probably be able to get the code all cleaned up (I admit it's messy) and bug-free within 24 hours. —Remember the dot (talk) 20:54, 10 September 2007 (UTC)


 * Yes, with the mixing of " and ', I'm truly surprised the entire site didn't collapse. : - ) --MZMcBride 21:27, 10 September 2007 (UTC)

OK, got the cleanup done! only problem remains the  '  and " in the image (hint) title: if I use  ' , all text in the hint past a  '  is truncated. If i use ", everything after " is truncated. If I use no quotes, everything after the first space disappears... I need a thridt quote character. :/ My code is here: http://commons.wikimedia.org/wiki/User:Edokter/monobook.js — Edokter  •  Talk  • 21:44, 10 September 2007 (UTC)
 * Now I find my edit toolbar on Commons don't work... (Update:) Must be a Commons problem, as the original code here also has this problem on Commons. But not here though... — Edokter  •  Talk  • 22:16, 10 September 2007 (UTC)

Code cleanup as requested
Here is a cleaned-up version of the code. I have tested it in my userspace on the Commons and believe that it will resolve the title attribute issues.

—Remember the dot (talk) 02:21, 11 September 2007 (UTC)
 * [[Image:Yes check.svg|20px]] Done. Cheers. --MZMcBride 02:30, 11 September 2007 (UTC)


 * Thanks! —Remember the dot (talk) 03:04, 11 September 2007 (UTC)
 * And thank you! Everything seems to be working now (even on Commons). — Edokter  •  Talk  • 08:30, 11 September 2007 (UTC)

Well, I found a new (small) problem. Have a look at resolved source and talk page. Apparrently the filter doesn't like exotic unicode characters in the image filename. There is probably no fix but to 'ban' exotic unicode in filenames (not sure what the policy is on that anyway). — Edokter  •  Talk  • 16:26, 11 September 2007 (UTC)
 * This is causing a problem with Route diagram template (see Wikipedia talk:Route diagram template), due to U-umlaut being used in some German-sourced images. --Dr Greg 17:23, 11 September 2007 (UTC)


 * Hopefully I'll be able to investigate this issue and find a fix within 24 hours. Please be patient. —Remember the dot (talk) 18:40, 11 September 2007 (UTC)


 * As far as I can tell, the filename is passed to the filter correctly, but after some digging, I think I found the cause: it is indeed AlphaImageLoader that is not handling the src parameter correctly. Here's some interesting reading: here. — Edokter  •  Talk  • 22:25, 11 September 2007 (UTC)


 * I wouldn't call it "exotic unicode" since I would consider Latin-1 characters pretty darn universal. (But you have a point with the atrociously named Image:☑.svg!!) Some other images that fail to render are Image:Bandera d'Öland.svg and Image:Île-de-France flag.svg. I don't think a massive renaming effort on Commons is the solution here, since that wiki is used by so many languages that use characters beyond good old ASCII.  I would expect plenty of image names with Latin-1 characters to be created perpetually after any renaming is "complete".  We need another solution.  Andrwsc 00:52, 12 September 2007 (UTC)
 * ☑ (which by now I found out is (U+2611) isn't latin-1; it's part of the "Miscellaneous Symbols" block see . The only fonts I could find that displays this character is Arial Unicode and MS UI Gothic. IE6 Seems to have a problem showing it (not Firefox), I still consider it an 'exotic' character, because not many fonts support it. — Edokter  •  Talk  • 11:44, 12 September 2007 (UTC)
 * Yes, of course, I agree that ☑ is a terrible filename, and I would clearly call that character "exotic". My point was that characters like Ö and Î aren't really "exotic" and therefore, we couldn't easily enforce a ban of them in image filenames just to support this fix.  It's a moot point now anyway.  Andrwsc 19:14, 13 September 2007 (UTC)
 * I never suggested that all unicode be banned, just that these 'exotic' ones be avoided in filenames. I have no problem with leters like öÎñéôÛáÈ (áñd whât èlsé); they are part of a language, and thus part of a codepage. That character isn't, which causes problem with readability (not only on IE6 btw), not to mention typeability. So yeah, in that respect I say ban those non-linguistic characters from filenames. — Edokter  •  Talk  • 19:31, 13 September 2007 (UTC)
 * I think we are in "violent agreement" with each other! Andrwsc 01:19, 14 September 2007 (UTC)

Bugfix part 2
The fix for the Unicode image naming problem is actually quite simple. I've debugged it on Commons and (with the help of, kudos to Edokter) found a fix. Just change

to

And change "Tweaked 11 Sep 2007" to "Tweaked 12 Sep 2007", or remove the date entirely if you like. —Remember the dot (talk) 02:44, 12 September 2007 (UTC)
 * [[Image:Yes check.svg|20px]] Done. Bit of a backlog in CAT:PER; it was good that you let me know. Cheers. --MZMcBride 03:41, 12 September 2007 (UTC)

Cheers Dot & MZ! I promise not to panic again if I find another bug (which I suspect won't happen for a long time). — Edokter  •  Talk  • 11:46, 12 September 2007 (UTC)


 * By the way, I'm working on an optimized version of the code that will hopefully run much faster than the current version. Please be patient; I'll probably have it done within 24 hours. —Remember the dot (talk) 18:56, 13 September 2007 (UTC)


 * Please take your time, no rush... Happy to help testing though (I can test on commons and nl.wiki). — Edokter  •  Talk  • 19:20, 13 September 2007 (UTC)

Other methods
Besides javascript to get IE6 to render PNS correctly, there are also other methods that may in the end be a better sulotion for MediaWiki. There are "CSS only" implementations, and even PHP solutions. This may be worth looking into in the long run. Just a thought... — Edokter  •  Talk  • 21:56, 13 September 2007 (UTC)

Optimized code
I went through and optimized the code to reduce unneccessary processing. Give this a try:

Now, even though I did cut out a bunch of unneccessary processing, I left in support for images with id and title attributes even though the MediaWiki software usually does not use these attributes on images. I didn't want to have this code work in most cases but seemingly randomly mess up the page's XHTML in others. —Remember the dot (talk) 04:45, 14 September 2007 (UTC)

Oh, and in case you were wondering, I did test this script on the Commons and it appears to work fine. —Remember the dot (talk) 04:48, 14 September 2007 (UTC)

I just made a minor change to the above code to improve performance a bit more. —Remember the dot (talk) 06:08, 14 September 2007 (UTC)
 * ✅ Done — M ETS 501 (talk) 16:38, 14 September 2007 (UTC)
 * Thank you! —Remember the dot (talk) 17:22, 14 September 2007 (UTC)
 * Is there a big fat list of PNG/SVGs on Commons somewhere, something like Route diagram template? Looks good so far, but can't test here (and that route diagram page is the utimate test page for this script.) — Edokter  •  Talk  • 11:20, 14 September 2007 (UTC)
 * Commons:Category:Diagrams has a nice collection of PNG and SVG images. —Remember the dot (talk) 20:34, 14 September 2007 (UTC)

editprotected

Thinking about this, I realized why the code has been dramatically slowing page load times on IE6. It's because the MediaWiki function "window.addOnloadHook" is executed before all the images load, causing the script to make browser the wait for every single image to load before displaying the page. Here is a revised version of the code that goes back to using "window.attachEvent", which will allow the browser to load all the images (though with opaque backgrounds) before changing the backgrounds to transparent. The end result for the user will be the ability to use the page freely with opaque backgrounds until all the images load, then the page will freeze for a moment (the user probably won't even notice this) while the backgrounds are made transparent.

This code also disables running the script on an image if the image uses an imagemap. In the current "live" script there is a bug that causes imagemaps to fail to work with PNG/SVG images.

Again, let me reiterate that this script is not nearly as good as upgrading to Internet Explorer 7 or using a different browser such as Firefox. Firefox does work on Windows 2000.—Remember the dot (talk) 20:34, 14 September 2007 (UTC)
 * ✅ Done — M ETS 501 (talk) 23:03, 14 September 2007 (UTC)
 * As of July 2007, about 38% of browser views were with IE5 or IE6 (see here). It's simply not practical to suggest that millions of potential users upgrade immediately.  Adoption will take time.  For the same reason, I would say that the Wikipedia experience is also way better on a large monitor (like my widescreen cinema display at home!), but since 2/3 of all users view with 1024x768 or smaller, we have to design pages for that.  Andrwsc 22:08, 14 September 2007 (UTC)


 * I'm not forcing users to upgrade, I'm merely strongly recommending it. Why would I write a script for IE6 if I was trying to force IE7 or Firefox on everyone? —Remember the dot (talk) 22:20, 14 September 2007 (UTC)

I found another possible problem, hopefully related the window.addOnloadHook method an possibly fixed by the change to window.attachEvent. Route diagram template containes a partially collapsed table containing SVGs. When clicking 'Show', I see no images in the resulting area being expanded, probably because they haven't been rendered yet? — Edokter  •  Talk  • 22:49, 14 September 2007 (UTC)


 * That's odd...I wonder if the bug described in the section below is related. —Remember the dot (talk) 23:23, 14 September 2007 (UTC)


 * Interestingly, if you click [edit] on one of those collapsible sections, and then click "Show preview", it works just fine. —Remember the dot (talk) 23:32, 14 September 2007 (UTC)
 * Maybe that particular page (over 400! SVGs) overloads the filter. BTW, now that it is changed to window.attachEvent, the filter still stalling IE after loading all the images, which may be related to the asynchronous loading of images described inthe article I mentioned earlier. — Edokter  •  Talk  • 23:59, 14 September 2007 (UTC)


 * Just so you know, the last code revision shifted the temporary freeze from before the page loads to after. This gives the user a chance to start reading the text of the article, and with any luck they'd be so caught up in that that they wouldn't notice the momentary freeze. On pages with just a few PNG or SVG images, the freeze is imperceptible anyway. —Remember the dot (talk) 05:00, 15 September 2007 (UTC)

New approach, far less problems
editprotected

In order to resolve the issues that the previous code caused, I request that the PngFix function be changed as follows:

This makes use of a different solution, leaving the  tags intact but filling in the proprietary filter property and then changing the   attributes to point to a 1px transparent GIF image. This allows for much faster code, support for imagemaps, resolves issues with the editing toolbar, and even allows MediaWiki's checkered image background to be displayed. The only downside is that the "Save Picture As" right-click menu item will try and save the 1px transparent GIF image instead of the image the user actually sees. I've tried to mitigate the problem as best I can by naming the image Image:Must left-click image again before saving.gif. —Remember the dot (talk) 17:10, 15 September 2007 (UTC)

Oh, and yes, I've tested this on the Commons, and it works great. —Remember the dot (talk) 17:10, 15 September 2007 (UTC)


 * Looks good to me. I'm not going to make the change, since I don't have IE to test it with, but I hope someone else can take care of this.  —Ilmari Karonen (talk) 19:16, 15 September 2007 (UTC)


 * It is lightning fast. Unfortunately, it breaks the  and   parameters again. This could be fixed using a CSS class, ie,  . —  Edokter  •  Talk  • 19:44, 15 September 2007 (UTC)


 * It's not truly broken, it just is missing part of the border. But, all the same, I'll disable the editprotected request until this is resolved. —Remember the dot (talk) 22:35, 15 September 2007 (UTC)


 * OK, this may sound drastic, but maybe the script should be removed from Common.js alltogether until all issues are resolved. That also allows for testing here on en:. — Edokter  •  Talk  • 22:55, 15 September 2007 (UTC)


 * Just hold on. Some templates have already switched to using SVG images and thus have become dependent on the functionality provided by this script. —Remember the dot (talk) 23:20, 15 September 2007 (UTC)

Improved though not revolutionized
editprotected

Well, I couldn't get the lightning-fast version to work right, but here is a revised copy of PngFix which will add support for transparency + imagemaps, support for the checkered background, and last if not least fix the edit toolbar problem.

—Remember the dot (talk) 23:57, 15 September 2007 (UTC)

Quick edit toolbar fix for the current version

 * Hold on, I found another problem :-( —Remember the dot (talk) 00:00, 16 September 2007 (UTC)

editprotected

OK, forget about the code above. Just change

if (imgSrc.substr(imgSrc.length - 3).toLowerCase == "png" && !img.useMap)

to

if (imgSrc.substr(imgSrc.length - 3).toLowerCase == "png" && !img.useMap && !img.onclick)

This will simply resolve the problem with the edit toolbar, no more. —Remember the dot (talk) 00:09, 16 September 2007 (UTC)


 * What was the problem? Imagemaps? The last version worked quite well and seemd indeed faster then the current one (though I would have to time both; is the img.outerHTML line the only difference apart from && !img.onclick ? ) — Edokter  •  Talk  • 00:29, 16 September 2007 (UTC)
 * OK, speed difference is minimal. Using img src made the image pop down 1px. Border/thumb works, toolbar works. I say go for it. Just curious what problem you found though. Oh and, should we clean up all the old code above, only leaving the current? — Edokter  •  Talk  • 00:53, 16 September 2007 (UTC)
 * The problem with the code posted to the top of this section is that it broke the links on every single image, making it impossible to click the image and get to its description page. And I'd prefer to leave all the discussion pages alone (don't cut the code out of them or anything). Just let this whole long section be archived in due time. —Remember the dot (talk) 05:04, 17 September 2007 (UTC)

Which version of the code should be changed to? Which change, exactly, should be made? There are a lot of suggestions in the above thread, and I'm not sure which one the request is to change. --ais523 14:38, 17 September 2007 (UTC)
 * I'd say the one that will come in a couple of weeks, and maybe will be at last tested just a tiny bit ∴ Alex Smotrov 15:33, 17 September 2007 (UTC)
 * Only the last change proposed by Remember the dot should be made to the current version for now; that will restore the editbuttons. — Edokter  •  Talk  • 16:08, 17 September 2007 (UTC)
 * Done. Personally, I'd recommend trying to get the "fast", non-inner/outerHTML based version working, since it looks like the only one that isn't likely to have such problems with unexpected attributes.  Unfortunately, I don't have IE at home so I can't help with this much.  —Ilmari Karonen (talk) 18:52, 17 September 2007 (UTC)
 * I agree on the fast version, but that will take some time testing to get all the bugs out. I'm sure Remember the dot is still working on it, and I will do some testing on my own. Stay tuned. — Edokter  •  Talk  • 19:39, 17 September 2007 (UTC)


 * Actually, I have not come up with any new way to fix all the problems perfectly, and I am not actively working on it. The code as it now stands should work for most if not all cases. That said, for increased flexibility I should probably write an algorithm to abort pngfixing an image if there are any unexpected attributes (not just usemap and onclick).
 * Please let me know about any specific cases where there are still problems. —Remember the dot (talk) 20:46, 17 September 2007 (UTC)


 * Actually, now I'm working on rewriting the code to avoid using proprietary properties (like  and  ). We'll have to see if this new approach is any faster. —Remember the dot (talk) 21:17, 19 September 2007 (UTC)

More standards-compliant version
I've modified the code to avoid using  to better comply with W3C standards, but the new code does not appear to be significantly faster. Would anyone else be willing to test this new code on, say, Commons:Category:Icons for railway descriptions, and let me know if it appears to go any faster?

—Remember the dot (talk) 01:58, 20 September 2007 (UTC)


 * While I'm usually all for standards compliance, in this case I don't think it's much of a priority, given that the code is meant to run only on specific versions of a single browser. Of course, I have nothing actually against it, either.  —Ilmari Karonen (talk) 03:23, 20 September 2007 (UTC)


 * I would prefer it for no other reason than to encourage standards-compliant JavaScript insofar as it is possible. But I was hoping that someone would be able to test the standards-compliant version and give a definitive answer as to whether it is faster or slower than the currently live code. The two seemed about the same when I tested them. —Remember the dot (talk) 03:46, 20 September 2007 (UTC)


 * Incidentally, I just removed the 6th line ("nextImage:") from the code. I did not mean to leave that in. It does not serve any purpose. —Remember the dot (talk) 03:48, 20 September 2007 (UTC)

Small bug found (I changed the code accordingly): if (img.parentElement.href) outerSpanStyle.cursor = "hand" Should be: if (img.parentElement.href) innerSpanStyle.cursor = "hand" Otherwise seems OK, not faster though, but I think the bulk of the speed is lost in the filter itself, not the javascript. Also, the images seem to load twice using the span method, something that was not the case with the src=blank.gif, which does speed up a bit. — Edokter  •  Talk  • 20:40, 21 September 2007 (UTC)


 * Actually, the bug was needing to change

outerSpanStyle = img.style

to

outerSpanStyle.cssText = img.style.cssText

All of the CSS styling for the outer span wasn't actually being applied. Thanks for catching that!

1px transparent image version
But...from your comments it sounded like you weren't having any problems with the solution that involves a 1px transparent image. So I tried that solution again and was not able to reproduce the problems I was having with it earlier. Here is a simplified version of that script, please let me know if it works all right for you:

—Remember the dot (talk) 03:17, 22 September 2007 (UTC)


 * Galley transparency works (checkered background), edit buttons work (even without the && !img.useMap && !img.onclick checks, don't know about imagemaps though, where can I find one on Commons?), but still has a problem with |border and |thumb attributes (image jumps up 1 or 2px, plus left 1px in left floats, and right/bottom border disappears).


 * Putting back sizingMethod='scale' seems to fix that problem, but then I see the image grow by 2 pixels as the filter is being applied. So it seems it doesn't quite handle the surrounding border properly. My testpage shows that quite clearly here. — Edokter  •  Talk  • 11:02, 22 September 2007 (UTC)
 * I've put in code that fixes the thumbborder/image mispacement. Not optimized, but it works. Scrap that, I found an even simpler sulution: sizingMethod='crop'! — Edokter  •  Talk  • 11:39, 22 September 2007 (UTC)
 * A test on nl.wiki shows that this code is significantly faster then the span method. Also a plus for this version: the added .thumbborder class is no longer needed in Common.css. — Edokter  •  Talk  • 12:13, 22 September 2007 (UTC)


 * Ah, now I remember why I didn't recommend using this 1px version + sizingMethod='crop'. It causes images to jump by a pixel or two when a border is used. Try  and you'll see what I mean. —Remember the dot (talk) 21:34, 22 September 2007 (UTC)


 * In that case, the only solution I can provide is this snipplet:

if (img.className == "thumbimage" || img.className == "thumbborder") {                 img.width = img.width - 2 img.height = img.height - 2 }


 * The only downside is that the border overlaps the image instead of enclosing it, basically cropping the image by 1px, but I think that's an acceptable compromise; I prefer the speed increase over the span method and can live with the virtually undetectable smaller image. — Edokter  •  Talk  • 23:07, 22 September 2007 (UTC)


 * I'm afraid this solution is unacceptable for two reasons. First, any alteration of the image's dimensions is unacceptable, as it could break the layout in some exotic cases. Second, your code relies on the image's border with being 1, and is hard-coded to that value. This will break if the border's width is ever changed. —Remember the dot (talk) 20:48, 24 September 2007 (UTC)

(Deindent) OK, here's some brainstorming... is it possible to enclose the within a span (as opposed to two spans), and have the span implement the border instead? (Edit: You tried this above). I still prefer this version, and I don't share your concern; First, the image dimension isn't really changed, and exotic layouts wouldn't normally use a border anyway. 2nd, I believe .thumborder and .thumbimage are not likely to be changed. — Edokter  •  Talk  • 21:26, 24 September 2007 (UTC)


 * The answer is still no. Let's think about your proposal for a minute.


 * Pros: Slightly decreased page load time, support for checkered background
 * Cons: Fragile, hard-coded values, significant potential for breaking or distorting pages


 * I wish just as much as you do that we could perfectly compensate for IE's quirky behavior. But honestly, the added speed and functionality you recommend is so little compared to the added problems this would create both now and in the future. the Any change that deviates from normal layout or presentation is unacceptable, especially when based on hard-coded values which may work today and break tomorrow. —Remember the dot (talk) 01:50, 25 September 2007 (UTC)


 * Make that signifcantly faster load times. The current code tends to lock up IE6 up to a minute when loading a page with 100+ PNGs, plus it ignores all imagemaps. I'd rather have the code removed entirely then have to deal with the wait time. I'll do some more tests with the combined code, but we should fret over 'hard-coded' values; Wikipedia of full of them. And also remember that it only impacts IE5.5/6.0, which is already "broken". — Edokter  •  Talk  • 09:01, 25 September 2007 (UTC)


 * First, the page freeze time is less than 5 seconds with the currently live code, and that's on a page with 200+ PNG/SVG images. On nearly all pages the page freeze time is less than 1 second. Most users will probably be too busy reading to even notice it.


 * Second, your personal preference, "I'd rather have the code removed entirely then have to deal with the wait time", is, sorry to say, rather irrelevant. The goal here was not to cater to the preferences of a single IE6 user. The goal was to correct one aspect of IE6's flawed behavior in certain circumstances so that the rest of us wouldn't have to worry so much about coding Wikipedia around it.


 * The goal was not to make IE6 render some pages better and some pages worse. This would just lead to a backlash and people puzzling over why things that worked before do not behave quite right now.
 * IE6 users have been asked for some time to either use a different browser, such as Firefox, or upgrade to version 7. If you're annoyed with poor performance in IE6, then why have you chosen not to do this?


 * —Remember the dot (talk) 19:01, 25 September 2007 (UTC)


 * I am seriously beginning to question your motives to put this script up in the first place; Are you trying to scare evey IE6 user away from it? It is not a mere 5 seconds, it's 65 seconds on Route diagram template (on a 1.4GHz), which is very bad. The code reduces it to 12. Now you won't compromise on a solution that would actually make the experience for IE6 user better, and now we're stuck with a half-working version. Tell you what... I'll come up with a solution myself and put that in; it won't distort the images and will make loading a lot faster for the majority of IE6 users.
 * To others, more input is always welcome, especially IE6 users. — Edokter  •  Talk  • 22:43, 25 September 2007 (UTC)


 * That's odd...when I was testing it before on the Commons, I only got an additional 5 seconds. I welcome your input, but I do not think that the solution you proposed is acceptable. Surely, though, you understand that IE6 is inferior to IE7, Firefox, Opera, Safari, and several others. You are doing yourself a disadvantage by continuing to use IE6.


 * Now, I took another look at the code that changes each image's source to a 1px transparent GIF (I actually could have used an indexed PNG, but the file size would have been slightly larger) and then encapsulates that element within a &lt;span>. I discovered that the reason it wouldn't work right is because the outer span's display style must not be "inline-block" for this solution. Here is some new code based on that idea that seems to work without problems:

—Remember the dot (talk) 02:57, 26 September 2007 (UTC)

Combination
The above code doesn't show the borders at all, and all images jump 1px to the left and down. Sorry if I seem a bit frustrated. I just think if it can be done right, it should be. I have been brainstorming a bit, and have come up with a mix of both methods, depending if there is a border or not. I just need to figure out how to create a outer span (I'm not that good in javascript); Here's the code I have tested so far; if you can integrate the above code into that part that needs a span, I think we actually have a very good solution:

That way, borderless images load fast (and pages with lots of images ususally don't have borders), while those with border are encapsulated in a span with border. No distortions, best of both worlds. — Edokter  •  Talk  • 13:31, 26 September 2007 (UTC)
 * Why can't I get any style information from img.style? it always comes back empty or 'undefined'. I can set it, but not read it. — Edokter  •  Talk  • 14:21, 26 September 2007 (UTC)


 * You're probably wanting to use ...
 * What you're recommending is essentially what I tried in the code immediately above this section. It puts all the CSS, including border information, into an outer span and then removes CSS from the image.
 * I'm really having a lot of trouble coming up with a way to make the code go very fast without distorting the images any or making them jump. For now, I would recommend switching to the code given at . I prefer this code for its increased standards-compliance, and it just might go a bit faster on Route diagram template. —Remember the dot (talk) 18:07, 26 September 2007 (UTC)
 * It is indeed similair to what you did, but with the difference that the span is only created for those image that need it. The 'Standards complient' code still has a problem with |border (but not with |thumb); the outerspan somehow does nog get the border attribute assigned. Probably the same problem I have with border being undifined somehow. — Edokter  •  Talk  • 18:36, 26 September 2007 (UTC)
 * Have you been making sure to bypass your cache after loading new JavaScript? —Remember the dot (talk) 18:44, 26 September 2007 (UTC)
 * Absolutely. But exploring it in the IE dev toolbar shows that the |border img does not have the border atrtributes it  should inherit form .thumbborder. — Edokter  •  Talk  • 18:48, 26 September 2007 (UTC)
 * Can we collaborate online somewhere, IRC maybe? I'm getting nowhere. It is pretty frustrating being full of ideas, but just not being able to pinpoint a problem. — Edokter  •  Talk  • 19:39, 26 September 2007 (UTC)
 * Just a note on your assumption above — "pages with lots of images" usually do have borders. Specifically, pages with hundreds of flag icons (e.g. List of countries) all use flag templates that put borders around every image.  Also note that these icons are also extremely sensitive to distortion (i.e. even one pixel makes a noticable difference), so it is very important to maintain the aspect ratio and not use the "scale" option.  Andrwsc 19:45, 26 September 2007 (UTC)
 * Noted. That's why I'm trying to get my solution above to work, but my knowledge of javascript fails me. I feel I'm on the verge of a breakthrough... I just need a little help. — Edokter  •  Talk  • 19:49, 26 September 2007 (UTC)
 * I need second eyes... I MUST be overlooking something stupid! Please look at . Why is  empty/undifened, and thus are the broders not showing??? (Test here.) —  Edokter  •  Talk  • 22:49, 26 September 2007 (UTC)


 * Because that information is defined in the thumborder class, not in the image's CSS text. You can use img.currentStyle to get at that information, but the code should really transfer the class information from the img element to the span used for styling.
 * Incidentally, did you have any problems getting the IE developer toolbar to install? It wouldn't work for me when I tried it earlier. In Firefox I can just use Firebug, but that's of little help here. —Remember the dot (talk) 00:37, 27 September 2007 (UTC)
 * Never mind. It did install OK, I just didn't know how to bring it up. —Remember the dot (talk) 01:10, 27 September 2007 (UTC)


 * About : I just tested it and the images are indeed receiving the thumbborder class. The IE developer toolbar confirms this. Can you double-check and see if you are still having that problem with this code? —Remember the dot (talk) 01:17, 27 September 2007 (UTC)


 * Never mind; you are receiving the thumbborder class, because it is in common.css; I didn;t have it in my common.css on Commons. However, you should no longer need to... I actually got my code to work! No distortions, showing borders, clickable, perfectly alligned, and no external .thumbborder class needed. The only thing to test are imagemaps, which I expect should work because it always uses an tag to show the image, and the containing span should pass all events. Please test my code.

(code moved down)

— Edokter  •  Talk  • 01:51, 27 September 2007 (UTC)


 * Your code causes the "A Wikimedia project" and "Powered by Mediawiki" buttons to disappear :-( —Remember the dot (talk) 01:58, 27 September 2007 (UTC)


 * OK, that's weird. They're there, but their clientHeight and clientWidth = 1 instead of the image dimensions, meaning it takes the transparent image's size. Hold on... — Edokter  •  Talk  • 02:27, 27 September 2007 (UTC)
 * Fixed. It was the 'crop', changed it to 'image' (phew). — Edokter  •  Talk  • 02:29, 27 September 2007 (UTC)

Imagemaps also work perfectly! So we can  So that leaves. What does that filter out and where can I test this? If the editing toolbar uses .onclick... then that is working as well. — Edokter  •  Talk  • 12:39, 27 September 2007 (UTC)
 * Added class independent border check. — Edokter  •  Talk  • 15:19, 27 September 2007 (UTC)


 * prevents the script from running on the edit toolbar buttons. Code that doesn't remove the original img element shouldn't need this filter.


 * I just tested your latest code, and there is still a visible upward jump on Commons:User:Edokter/pngtest.


 * For the moment, I'd recommend switching to until better code is found. —Remember the dot (talk) 17:03, 27 September 2007 (UTC)


 * I don't even see the jump on Commons, and the page layout does not suffer in any way. Besides, I think it's a side effect of the filter kicking in and the browser adjusting it's layout. If that is the only problem, I'd recommend making this code live. It solves more problem then they current code causes. — Edokter  •  Talk  • 17:37, 27 September 2007 (UTC)


 * You might not be seeing the jump because Commons:User:Edokter/monobook.js still uses the "addOnloadHook" function, which was removed from the code here because it caused some very bad speed issues. It causes IE6 to load all the images on the page before it displays it, which is very bad.


 * I do not want to mess up the layout of pages, which is what your new code would do. My recommended code is slower, but it does not introduce new layout problems. Actually, switching to might even speed page loading up a bit. —Remember the dot (talk) 18:37, 27 September 2007 (UTC)


 * Then we have a difference of opinion. I pose that the difference in layout is less compared the difference in layout between IE and Firefox, and that it does not damage the layout in anyway, yet offers more functionality and speed then the current code. I think IE6 users benefit more with the added functionality then the 1px jump that does not harm the layout in anyway; the images are not distorted; the only visible effect is a 1px vertical margin drop in images with borders, and like you said, it can never be perfect. — Edokter  •  Talk  • 19:50, 27 September 2007 (UTC)

OK, try again. — Edokter  •  Talk  • 23:37, 27 September 2007 (UTC)

Compliant version

 * Unfortunately, it's still jumping.




 * I request that the PngFix function be changed to use the code at . The function will still behave the same way, but it will encourage using standards-compliant code. In other words, it will set a good example for others who wish to add JavaScript to MediaWiki:Common.js or their personal JavaScript files. It also may decrease page load time.


 * Notwithstanding, should better code be found I'm all for it. —Remember the dot (talk) 02:39, 28 September 2007 (UTC)


 * ✅ Though only for the sake of 'being compliant'. I still regard that code as broken because imagemaps don't work, so if I find an solution for the jump, which I think is not even a problem, I'll put my code in immediately. Of course, you may want to pitch in; the jump is related to the font-size and the span's margin being off by 1px. Ultimately, we should avoid using the inner span for the image; it breaks too much functionality. — Edokter  •  Talk  • 08:53, 28 September 2007 (UTC)


 * Thanks! But what functionality does my code break? I thought I put in sufficient checks to make it not run in cases where it won't work right. The thing that's really doing the "breaking" here is Internet Explorer 6. You can see why I don't recommend it.


 * When you get your code working, could you do me the courtesy of giving me an opportunity to double-check it before you make it live? —Remember the dot (talk) 17:09, 28 September 2007 (UTC)


 * It doesnt break anything perse, but it doesn't display all PNG as transparent, I consider that broken. I'll continue working on my code. Why don't you hop over to commons:User talk:Edokter/pngtest where we can discuss without filling up this page? — Edokter  •  Talk  • 18:20, 28 September 2007 (UTC)

Javascript issue with collapsible tables
There is an issue where an incorrectly formatted collapsible table causes a JS error. That doesn't look like much of a problem, but it also means that all JS that should be run after this specific function stops dead in its tracks.

The problem is in function createCollapseButtons. Before this is run, there should be  checks that verify if there are any   and   elements at all in the table. --TheDJ (talk • contribs) 22:12, 14 September 2007 (UTC)
 * Just below it is actually an  check. If that is move up to the top of this loop, before the button and links are created, then the issue is solved. Seems the easiest approach in this case. --TheDJ (talk • contribs) 22:25, 14 September 2007 (UTC)
 * Thanks for the report. —Ilmari Karonen (talk) 19:13, 15 September 2007 (UTC)

modifier script
This script turns the "&#91; edit &#93;" link into an href (such as the one that allows editing of a section on a page). Would anyone be opposed to its addition to MediaWiki:Common.js? —  Animum  |  talk  14:35, 30 September 2007 (UTC)


 * Huh? What do you think the "[edit]" link does now? Mike Dillon 15:21, 30 September 2007 (UTC)


 * Hardcoding text messages within javascript is not desireable; that is why MediaWiki has Special:Allmessages. Browser complains about a missing ";" too. — Edokter  •  Talk  • 18:47, 30 September 2007 (UTC)