Module talk:Citation/CS1/Archive 1

Minor bug in position of period
Note the position of the "." after "(PDF)" in cite web but before it in cite web/lua:

(Also note that the publisher is being duplicated as of this diff I think) —&#91;  Alan M 1  (talk) &#93;— 19:19, 19 February 2013 (UTC)
 * Fixed dot & duplicate publisher: Thank you for testing the {cite_web/lua} format, which uses a completely different method of joining parameters, compared to {cite_web}. -Wikid77 (talk) 21:01, 19 February 2013 (UTC)

Discrepancy in position of page number
Page parameter has moved:

—&#91;  Alan M 1  (talk) &#93;— 19:29, 19 February 2013 (UTC)
 * Shifted page after date: Thanks again for testing the {cite_web/lua} format. -Wikid77 (talk) 21:01, 19 February 2013 (UTC)

Missing period after work parameter
This demonstrates a missing period after the work parameter:

(publisher is wrapped in parens and dup'd, too, but this may be a temporary thing) —&#91;  Alan M 1  (talk) &#93;— 19:37, 19 February 2013 (UTC)
 * Parentheses are for journal format: The {cite_web/lua} adds parentheses around "(publisher)" when it thinks the cite is for a journal (as variable "Periodical"), so that has caused the confusion. -Wikid77 (talk) 21:01, 19 February 2013 (UTC)

Extra . before publisher
-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)
 * Fixed to match. -Wikid77 05:20, 21 February 2013 (UTC)

Wrong link when archiveurl specified and deadurl=no
-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)
 * Fixed to match. -Wikid77 21:37, 20 February 2013 (UTC)

reference-accessdate class
The access date should be wrapped in allowing readers to hide the access date as desired.

--— Gadget850 (Ed) talk 20:26, 20 February 2013 (UTC)
 * Fixed to match. -Wikid77 21:37, 20 February 2013 (UTC)

OCLC
The OCLC identifier link needs be updated from Online Computer Library Center to OCLC to reflect their name change. --— Gadget850 (Ed) talk 21:21, 20 February 2013 (UTC)
 * Changed to match. -Wikid77 22:46, 20 February 2013 (UTC)

COinS formatting
It appears that the COinS data being presently generated is invalid due to overencoding.





The hidden COinS data in the final span renders to HTML as (with some breaks add for line spacing):



<span class="Z3988" title="ctx_ver=Z39.88-2004&amp;rft_id=info%3Adoi%2F%31%30.DOI_number&amp;rft_id=info%3Aoclcnum%2FOclc+%34%35&amp;rft.aulast=Doe&amp;rft.isbn= %31%32%33%34%35%36%37%38%39%30&amp;rft.place=Vienna&amp;rft.volume=IV&amp;rft_id=http%3A%2F%2Faustria-forum.org%2Faf%2FAEIOU&amp;rft.atitle=&amp;rft.genre=bookitem&amp;rft.edition= %32%30%31%32&amp;rft.au=Doe%2C+J.B.&amp;rft.aufirst= J.B.&amp;rft.pub=BMBWK%2C+Austria&amp;rft.date=%31+December+%32%30%31%32&amp;rft.pages= %37%37&amp;rft.jtitle=AEIOU+Encyclopaedia&amp;rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook&amp;rft.btitle=Mein+Artikel&amp;rfr_id= info:sid/en.wikipedia.org:Special:ExpandTemplates" style="display: none;">&#160;

This is a change from the format generated by the COinS template, which looks like:



<span class="Z3988" title="ctx_ver=Z39.88-2004&amp;rft_id=info%3Adoi%2F%31%30.DOI_number&amp;rft_id=info%3Aoclcnum%2FOclc+%34%35&amp;rft.aulast=Doe&amp;rft.isbn= %31%32%33%34%35%36%37%38%39%30&amp;rft.place=Vienna&amp;rft.volume=IV&amp;rft_id=http%3A%2F%2Faustria-forum.org%2Faf%2FAEIOU&amp;rft.atitle=&amp;rft.genre=bookitem&amp;rft.edition= %32%30%31%32&amp;rft.au=Doe%2C+J.B.&amp;rft.aufirst= J.B.&amp;rft.pub=BMBWK%2C+Austria&amp;rft.date=%31+December+%32%30%31%32&amp;rft.pages= %37%37&amp;rft.jtitle=AEIOU+Encyclopaedia&amp;rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook&amp;rft.btitle=Mein+Artikel&amp;rfr_id= info:sid/en.wikipedia.org:Special:ExpandTemplates"> &#160;

Even I'm inclined to believe this looks like a trivial change, but it is enough to break the Chrome based COinS to OpenURL interpreter that I used as a testing agent. It doesn't work correctly if the COinS span is styled as "display: none". I don't know if other COinS clients are more tolerant, but it seems like using the same styling as the COinS template probably makes sense. Dragons flight (talk) 23:21, 11 March 2013 (UTC)


 * I went ahead and changed this to use the same kind of extra empty span as the COinS template. Dragons flight (talk) 00:05, 12 March 2013 (UTC)
 * The empty span is required to keep HTML Tidy from stripping out the COinS data. --— Gadget850 (Ed) talk 00:58, 12 March 2013 (UTC)

Location in cite web
It appears that the Lua version of cite web ignore the location field. Incidentally, if the user chose cite_news (a more logical choice) rather than cite_web, the location field would have been handled correctly, but we can't really count on users being logical. Example taken from a reference actually in use. Dragons flight (talk) 15:35, 12 March 2013 (UTC)
 * Fixed. -Wikid77 11:19, 13 March 2013 (UTC)

Possible improvement: remove extra quotes from the quote field
Sometimes users wrap the quote= field in an unnecessary set of quotation marks. It might be nice to automatically detect and correct for this situation. Dragons flight (talk) 16:03, 12 March 2013 (UTC)


 * I went ahead and implemented this improvement. Dragons flight (talk) 03:47, 13 March 2013 (UTC)
 * I agree that seems an intuitive option, and I cannot imagine any significant confusion, compared to new users typically setting quote="xx yy" as a logical format. -Wikid77 10:13, 13 March 2013 (UTC)

Lost location tag in cite encyclopedia / editor label
The Lua version drops the location information. In addition, both the old and the new citation give a somewhat strange treatment to the "editor" label. I assume the goal is to say that it is in the encyclopedia that James Hastings edited, but the placement of the label "In" before his name looks weird. Dragons flight (talk) 17:49, 12 March 2013 (UTC)
 * Fixed to match. -Wikid77 11:19, 13 March 2013 (UTC)
 * The "In" is deliberate and mostly in line with APA; see Purdue OWL under "Article or Chapter in an Edited Book". --— Gadget850 (Ed) talk 12:33, 13 March 2013 (UTC)

Blank parameters creates extra periods
Here the location and publisher fields are included but blank. This results in an extra period in Lua. Dragons flight (talk) 12:34, 13 March 2013 (UTC)


 * Fixed. Dragons flight (talk) 01:58, 14 March 2013 (UTC)

Format and language transposed
-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)
 * Fixed to match. -Wikid77 21:37, 20 February 2013 (UTC)

No warning if archiveurl specified and archivedate is not
-- WOSlinker (talk) 22:34, 19 February 2013 (UTC)

No printonly URL
First difference I've spotted is has a  tag for urls but this is not included in. (Copied from Template talk:Citation/core)

Compare
 * Result:
 * Result:
 * Result:
 * Result:

no normal visible difference but the html sources are considerable different

"Ministry of Home Affairs (Department of Border Management)" (DOC). http://mha.nic.in/docs/BM_Intro(E).doc. Retrieved 1 September 2008. .

"Ministry of Home Affairs (Department of Border Management)" (DOC). Retrieved 1 September 2008. &#160;. The latter has the CoiNS but no printonly.--Salix (talk): 20:07, 20 February 2013 (UTC)


 * Is that really needed? When I try a print preview in both Firefox & IE, the current cite web version shows the URL twice. With the lua version, it only shows the URL once. Does it need to be shown twice for the printed version? -- WOSlinker (talk) 20:19, 20 February 2013 (UTC)


 * It seems that it might not be, there is a css rule for the a.external.text class which inserts the url and the printonly span duplicates this behaviour commonPrint.css.

Looks like this is a bug in. However it does require the user agent can work with the :after css tag. --Salix (talk): 22:33, 20 February 2013 (UTC)

Empty url parameter
that is leaves a trailing [ ]. The authorlink suggests that link and url parameters that are empty are still being actioned, rather than ignored. RDBrown (talk) 21:51, 20 February 2013 (UTC)
 * Fix in progress. I think I found the Lua code to fix, for person.link ~= "" to bypass any empty authorlink or editorlink. We also need to ignore any empty "author=" to use "last=xx" instead. -Wikid77 22:46, 20 February 2013 (UTC)
 * While the fix looks better, linking the title to the URL generated for the PMC is failing now.
 * I've added the prior cite journal for comparison. Please also remove the superfluous ?tool=pmcentrez from the link URL RDBrown (talk) 05:00, 21 February 2013 (UTC)
 * Yes- I removed that from citation/identifier a few months ago. --— Gadget850 (Ed) talk 11:30, 22 February 2013 (UTC)
 * Removed 'pmcentrez' from both PMC links. I finally understood how both PMC links no longer need 'pmcentrez' (I think). -Wikid77 Wikid77 (talk) 17:30, 26 February 2013 (UTC)

et al.
CS1 templates do not italicize et al., as it is a commonly used term. There is an extra period after et al.

--— Gadget850 (Ed) talk 01:11, 21 February 2013 (UTC)
 * Fixed to match. -Wikid77 05:20, 21 February 2013 (UTC)

Identifiers

 * asin-tld not working:


 * ssrn not working:

--— Gadget850 (Ed) talk 14:02, 21 February 2013 (UTC)
 * Fixed to match SSRN and lowercase "asin-tld". There had been a typo where SSRN would not display without id "RFC".
 * cite_journal    +asin-tld:
 * cite_journal/lua +asin-tld:
 * With option "asin-tld=ca" then the ASIN URL uses "amazon.ca" instead of "amazon.com". Lua version now allows lowercase "asin-tld" or uppercase "ASIN-TLD". -Wikid77 15:12, 21 February 2013 (UTC)

There is no check on asin-tld for valid values: Valid: co.jp, co.uk, ca, cn, fr, de, it or es --— Gadget850 (Ed) talk 18:22, 21 February 2013 (UTC)
 * See thread below:.

Future changes impact 1.7 million articles
We need to fix most problems in the next few weeks. The current Module:Citation/CS1 puts all 1.7 million "eggs in one basket" to require reformatting of all Lua-cite articles in the future, as if any future change were like a change to Template:Citation/core. Note how this is unlike the 23-way cite-template forks' "division of labor" of the current 23 cite templates (such as {cite_encyclopedia} or {cite_video} ). Hence, we should avoid creating self-imposed limits which require future changes to the central Lua module. In particular, any Lua-based restriction in a parameter to report new values as "errors" could require changing the shared Lua module and reformatting all 1.7 million articles, to allow a parameter to use a new "valid" value. A potential hybrid approach would be to validate some parameters in the shell templates before they each  the Lua module, or otherwise to pass a template-internal parameter of "allowable values" which the Lua module would scan against the related cite parameter. This could be run very fast in Lua, as essentially, a scan for nation code in a string "ca de co.jp es fi fr co.uk it sv us" where the logic would report any other code as failing to match the rapid scan of valid codes. The string of nation codes would be contained (and changed) in the shell template, as a validation parameter passed into Module:Citation/CS1 which would not be changed, and not force reformatting of all 1.7 million Lua-cite articles, but perhaps limited to only {cite_journal} or just a few template shells where the validation is considered vital to avoiding user pilot error. -Wikid77 (talk) 20:41, 21 February 2013 (UTC)

Transition Phase-2: testing in major articles
I encourage others to edit-preview some major articles and report results below, for perhaps 50 articles of different subjects. -Wikid77 19:31, 22 February 2013 (UTC)

Tests in various articles: The following have been tested:
 * 1) India - used {citation/lua} and had to fix ref=xx to override the implicit "ref=harv" which {citation} triggers. All {citation/lua} showed correct span-tags: &lt;span id="CITEREF..." class="citation"&gt; and Harvard referencing cross-linked when author/year clicked. Edit-preview dropped from 28 to 17 seconds. -Wikid77 19:31, 22 February 2013 (UTC)
 * 2) United States - has many short cites, with 210 {cite_web}, 29 {cite_news} and 37 {cite_book}, so created {cite_book/lua}. Edit-preview dropped from 22 to 11 seconds. -Wikid77 19:31/22:03, 22 February 2013 (UTC)
 * 3) Pneumonia - test of edit-preview has just begun. -Wikid77 19:31, 22 February 2013 (UTC)
 * 4) Costa Concordia disaster - as trendy topic from January 2012, uses 199 {cite_news}, 41 {cite_web}. Edit-preview dropped from 21 to 9 seconds. -Wikid77 22:03, 22 February 2013 (UTC)
 * 5) New York City – Diff between  and  where type (# of occurrences) in {web (233)|news (61)|book (35)|journal (7)}:

< Lua > quick

43c43 <    ^ "Statue of Liberty". World Heritage. © UNESCO World Heritage Centre 1992–2011. Retrieved 2011-10-23. --- >    ^ "Statue of Liberty". World Heritage (© UNESCO World Heritage Centre 1992–2011). Retrieved 2011-10-23. 85c85 <    ^ Miller, Christopher L., George R. Hamell; Hamell, George R (September 1986). "A New Perspective on Indian-White Contact: Cultural Symbols and Colonial Trade". The Journal of American History (Organization of American Historians) 73 (2): 311: 311–328. doi:10.2307/1908224. JSTOR 1908224. --- >    ^ Miller, Christopher L., George R. Hamell; Hamell, George R (September 1986). "A New Perspective on Indian-White Contact: Cultural Symbols and Colonial Trade". The Journal of American History (Organization of American Historians) 73 (2): 311–328. doi:10.2307/1908224. 111c111 <    ^ "Missing Doctor Added to List of 9/11 Victims". © 2002-2013 TWO SL LLC, New York, NY. All rights reserved. Associated Press. July 2008. Retrieved 2013-02-21. --- >    ^ "Missing Doctor Added to List of 9/11 Victims". Associated Press. © 2002-2013 TWO SL LLC, New York, NY. All rights reserved. July 2008. Retrieved 2013-02-21. 139c139 <    ^ Greene and Harrington (1932). American Population Before the Federal Census of 1790., as cited in: Rosenwaike, Ira (1972). Population History of New York City. Syracuse, N.Y.: Syracuse University Press. p. 8. ISBN 0-8156-2155-8. --- >    ^ Greene and Harrington (1932). American Population Before the Federal Census of 1790. New York., as cited in: Rosenwaike, Ira (1972). Population History of New York City. Syracuse, N.Y.: Syracuse University Press. p. 8. ISBN 0-8156-2155-8. 168c168 <    ^ Kirk Semple (June 23, 2011). "Asian New Yorkers Seek Power to Match Numbers". The New York Times. Retrieved 2011-07-05. "Asians, a group more commonly associated with the West Coast, are surging in New York, where they have long been eclipsed in the city's kaleidoscopic racial and ethnic mix. For the first time, according to census figures released in the spring, their numbers have topped one million—nearly 1 in 8 New Yorkers—which is more than the Asian population in the cities of San Francisco and Los Angeles combined.". --- >    ^ Kirk Semple (June 23, 2011). "Asian New Yorkers Seek Power to Match Numbers". The New York Times. Retrieved 2011-07-05. "Asians, a group more commonly associated with the West Coast, are surging in New York, where they have long been eclipsed in the city's kaleidoscopic racial and ethnic mix. For the first time, according to census figures released in the spring, their numbers have topped one million—nearly 1 in 8 New Yorkers—which is more than the Asian population in the cities of San Francisco and Los Angeles combined." 254c254 <    ^ Newman, Michael (2005). "New York Talk". in Wolfram, Walt; Ward, Ben.American Voices. Blackwell. pp. 82–87. ISBN 1-4051-2109-2. --- >    ^ Newman, Michael (2005). "New York Talk". American Voices. Blackwell. pp. 82–87. ISBN 1-4051-2109-2. 272c272 <    ^ "Owners warm up to New York/New Jersey as Super Bowl XLVIII host". NFL.com. Associated Press. May 26, 2010. Retrieved 2010-05-27. "It's the first time the league has gone to a cold-weather site that doesn't have a dome ... the NFL will wait and see how this foray into the great outdoors in winter goes. Then the league might OK another bid". --- >    ^ "Owners warm up to New York/New Jersey as Super Bowl XLVIII host". NFL.com (Associated Press). May 26, 2010. Retrieved 2010-05-27. "It's the first time the league has gone to a cold-weather site that doesn't have a dome ... the NFL will wait and see how this foray into the great outdoors in winter goes. Then the league might OK another bid" 283c283 <    ^ Sassen, Saskia (2001). The Global City: New York, London, Tokyo (2nd edition). Princeton University Press. ISBN 0-691-07063-6. --- >    ^ Sassen, Saskia (2001). The Global City: New York, London, Tokyo. Princeton University Press (2nd ed.). ISBN 0-691-07063-6. 304c304 <    ^ Orr, James and Giorgio Topa (Volume 12, Number 1, January 2006). "Challenges Facing the New York Metropolitan Area Economy" (PDF). Current Issues in Economics and Finance – Second District Highlights. New York Federal Reserve. Retrieved 2008-09-01. --- >    ^ Orr, James and Giorgio Topa (Volume 12, Number 1, January 2006). "Challenges Facing the New York Metropolitan Area Economy" (PDF). Current Issues in Economics and Finance – Second District Highlights (New York Federal Reserve). Retrieved 2008-09-01. 328c328 <    ^ Rachel Weinberger, John Kaehny, Matthew Rufo (2010). "U.S. Parking Policies: An Overview of Management Strategies". Institute for Transportation and Development Policy. p. 62. Retrieved 2011-06-11. "New York City is the largest, densest and most transit- and pedestrian-oriented city in the United States. It is the only U.S. city in which a majority of households do not have a car. Despite this, New York City is very much an American city in the way it under prices and under uses curbside parking meters. Meter rates are far lower than in other leading world cities, and New York suffers from high levels of cruising and double parking (p 62) ... Nationally 90% of households own automobiles. New Yorkers own fewer at 48% with only 22% of Manhattan residents owning automobiles (page 78)". --- >    ^ Rachel Weinberger, John Kaehny, Matthew Rufo (2010). "U.S. Parking Policies: An Overview of Management Strategies". Institute for Transportation and Development Policy. p. 62. Retrieved 2011-06-11. "New York City is the largest, densest and most transit- and pedestrian-oriented city in the United States. It is the only U.S. city in which a majority of households do not have a car. Despite this, New York City is very much an American city in the way it under prices and under uses curbside parking meters. Meter rates are far lower than in other leading world cities, and New York suffers from high levels of cruising and double parking (p 62) ... Nationally 90% of households own automobiles. New Yorkers own fewer at 48% with only 22% of Manhattan residents owning automobiles (page 78)" 337c337 <    ^ Johnson, Bruce D., Andrew Golub, Eloise Dunlap (2006). "The Rise and Decline of Hard Drugs, Drug Markets, and Violence in Inner-City New York". in Blumstein, Alfred, Joel Wallman.The Crime Drop in America. Cambridge University Press. ISBN 0-521-86279-5.; Karmen, Andrew (2000). New York Murder Mystery: The True Story Behind the Crime Crash of the 1990s. NYU Press. ISBN 0-8147-4717-5. --- >    ^ Johnson, Bruce D., Andrew Golub, Eloise Dunlap, ed. (2006). "The Rise and Decline of Hard Drugs, Drug Markets, and Violence in Inner-City New York". The Crime Drop in America. Cambridge University Press. ISBN 0-521-86279-5.; Karmen, Andrew (2000). New York Murder Mystery: The True Story Behind the Crime Crash of the 1990s. NYU Press. ISBN 0-8147-4717-5. 345c345 <    ^ New York in Focus: A Profile from Census 2000 (PDF). Brookings Institution. November 2003. Retrieved 2008-09-01. --- >    ^ "New York in Focus: A Profile from Census 2000" (PDF). Brookings Institution. November 2003. Retrieved 2008-09-01. 367c367 <    ^ "Holland Tunnel". National Historic Landmark Quicklinks. National Park Service. Retrieved 2012-03-22. --- >    ^ "Holland Tunnel". National Historic Landmark Quicklinks (National Park Service). Retrieved 2012-03-22.

Times were similar between the two. —&#91;  Alan M 1  (talk) &#93;— 22:20, 22 February 2013 (UTC)
 * 1) Riemann hypothesis. Preview sped up from 15s with citation to 7s with citation/lua. I did not check all the harv-template links, but spot-checking found no problems with them. There were various minor formatting changes, some of them bugs:
 * Fixed space after editor: I have added the missing space after the author's editor name, and switched "in" to "In" when not {citation} format. I need more time to fix the "et al" format. -Wikid77 (talk) 02:14, 23 February 2013 (UTC)


 * In the Borwein et al. reference, citation uses a semicolon before "et al.", citation/lua doesn't.
 * In the Cartier and Ingham references, citation doesn't use a comma between the series and volume (I consider this to be an improvement).
 * In the Ivić 2008 reference, lua again doesn't put a semicolon before the "et al.", but it also doesn't put a period after it, and it doesn't include a space between the following comma and the book title (this appears to be a bug).
 * The same missing space is also a problem in the Montgomery 1983 reference.
 * In the Sarnak 2008 reference, besides the missing space, the "(PDF)" format has moved from the authors to the book title (an improvement, but the chapter title would be even better).
 * The same format=PDF move happens in the Stein and Mazur reference, where it is now in the correct place.
 * In the Titchmarsh 1935 and 1936 refs, and Zagier 1981, the publisher has moved from the journal name to the issue number; I think the old location was better.


 * —David Eppstein (talk) 22:27, 22 February 2013 (UTC)

Add other tests into the list above. Thanks. -Wikid77 19:31, 22 February 2013 (UTC)

ISBN link
There has been a discussion about changing/removing the ISBN link. See Talk:International_Standard_Book_Number. -- Alan Liefting (talk - contribs) 00:05, 23 February 2013 (UTC)

Apologies for whack-a-mole updates
This past week, I have recently made over 120 changes to the format of the Lua-based citations. If people are perplexed by all the tiny format differences, at this late date, then let me apologize for the all the myriad changes to the Lua module, as if playing "Whac-A-Mole" to swat the latest crisis of the hour. Just today, I had to update the Lua module to add "given=xx" as an alternate first name for "given1". As we discussed, months ago, all the aliases among the ~430 parameter names in the Lua module (such as "author-link" or "authorlink" or "author1-link") have created a nightmare of format details, where simulating the same format in Lua, to match the prior markup-based templates, requires the eventual tracking and testing of thousands of parameter settings. Meanwhile, we can focus on getting the major 90 parameters in place, now, to begin using the rapid Lua-based cite templates, and fix other formatting issues during future weeks. Just hang in there, and keep testing, even though it might seem to be a bottom-less pit of problems, the results are getting better every day. -Wikid77 (talk) 08:09, 23 February 2013 (UTC)
 * Returned to fixes after some days of analysis: I have verified the handling of a few hundred more cite parameters, mostly for author, last, first, authorlink and author-link, using more test cases. See:
 * wp:CS1/test_parameters - simple cases to test all 430 or more parameters
 * I have also moved the "type=" data to follow the "format=" data. I will check the placement of "coauthor=" with author names. It had taken me some extra days to face the reality of how hundreds of changes were needed, simply because having hundreds of options is very tedious to match. -Wikid77 (talk) 17:30, 26 February 2013 (UTC)

et al. and spaces
Author, Given; Auth2, Given2;  Auth3, Given3;  Auth4, Given4; Auth5, Given5; Auth6, Given6;  Auth7, Given7;  Auth8, Given8;  et al. (23 February 2013). "Test author+given".

This seems to be adding an extra space, visible in the HTML, after the semicolons. Also, the current cite web template doesn't have a semicolon before the "et al". Is that an intentional change, because it looks strange to me. Dragons flight (talk) 18:49, 11 March 2013 (UTC)
 * Extra spaces are ignored when rendering html, so this is not a problem. (I don't have a strong opinion on the semicolon change.) —David Eppstein (talk) 19:01, 11 March 2013 (UTC)
 * The extra spaces aren't important to the reader, that's true, but it's also an apparently superfluous change. In general, it's good to avoid unnecessary changes as it is often hard to predict what bots or external tools might be surprised by silly little changes in the HTML.  Ideally, the HTML should be identical, except for the things we are intentionally changing.  Dragons flight (talk) 20:00, 11 March 2013 (UTC)

Print only for URL

 * Lua cite web




 * Old cite web



The new Lua version appears to be missing the hidden, printonly URL text, which is there to preserve the URL information since one can't click on a print-out. Dragons flight (talk) 22:06, 11 March 2013 (UTC)


 * Well, there is a reason for that. If you try printing a page using current live template, you will end up with the URL's shown twice. -- WOSlinker (talk) 22:47, 11 March 2013 (UTC)


 * You appear to be correct, verified on my recent versions of Chrome, Firefox, and IE. Do you know whether this is a relatively well supported feature?  I agree with removing the printonly portion as long as nearly everyone is going to get the URL address anyway.  Dragons flight (talk) 23:41, 11 March 2013 (UTC)

archive urls
Is this a deliberate change? When using the archiveurl= option, the current behavior is to link first the archive page, and then to the "the original", while this seems to have been reversed in the module.

If "deadurl=no" is specified the old behavior is the same as the current behavior.

Was the change in the first case deliberate? The second case appears to be discussed earlier on this page, but I don't see any discussion of the first case above. Dragons flight (talk) 03:26, 12 March 2013 (UTC)


 * I've fixed this by changing the default behavior for deadurl. Dragons flight (talk) 02:49, 13 March 2013 (UTC)

doi_brokendate
This is an obscure journal parameter that doesn't seem to be supported yet. Dragons flight (talk) 05:06, 12 March 2013 (UTC)


 * Fixed. Dragons flight (talk) 04:19, 13 March 2013 (UTC)

ArXiv links are broken
The above example shows that the ArXiv URL is broken under Lua due to an encoding issue. Dragons flight (talk) 05:15, 12 March 2013 (UTC)
 * Aren't those two supposed to be completely equivalent? But maybe arxiv's server isn't properly compliant. Anyway, we shouldn't be urlencoding that slash — it has no useful effect, doesn't work (perhaps due to a bug at arxiv), and just makes it harder for humans to read it. —David Eppstein (talk) 07:15, 12 March 2013 (UTC)


 * No, not at all. According to the standard percent encoding is supposed to change the meaning of control characters.  The character "/" is supposed to be interpreted as a path separator while the character "%2F" is supposed to be interpreted as the ASCII character "/" and not as a path separator.  Let me give an example:


 * http://www.example.com/some_dir/24%2F7.html means look for a file named "24/7.html" on the path "some_dir"
 * http://www.example.com/some_dir/24/7.html means look for a file name "7.html" in the directory "24" that is a subdirectory of "some_dir".


 * These are not equivalent things. It is not uncommon to see web servers that actually treat "%2F" and "/" as identical in all cases, but that is not compliant with URI standard.  The fact that ArXiv treats these two situations as different is actually what they should be doing according to the standard.  We are the ones that are not handling this correctly.  Dragons flight (talk) 14:44, 12 March 2013 (UTC)


 * Fixed. Dragons flight (talk) 03:41, 13 March 2013 (UTC)

Period after quote
It appears as though the Lua code adds a period after all quotes. This might be an improvement in some cases, but if the quote already contains a period at the end, adding a second period is probably incorrect behavior. I'm not sure whether is better to never add a period (the present behavior), or to check for the presence of punctuation at the end of the quote and add a period only if no punctuation is found. Dragons flight (talk) 15:12, 12 March 2013 (UTC)
 * The current CS1 style as documented is for no postscript punctuation when quote is present, as the quote is usually added with a terminal period or question mark. --— Gadget850 (Ed) talk 15:21, 12 March 2013 (UTC)


 * Removed end-dot after quote parameter: I agree that matching the prior quotation style will avoid problems, so I set variable enddot="" when Quote~="". In general, the final step is to check conditions which change the final enddot to the "" null string, because Lua is so fast when checking dozens of if-statement conditions. -Wikid77 (talk) 10:13, 13 March 2013 (UTC)

Multiple editors, plural
When multiple editors are specified, the present version of cite book marks them as "eds." while the Lua version uses only "ed." Dragons flight (talk) 16:07, 12 March 2013 (UTC)


 * Added plural option. Dragons flight (talk) 04:00, 13 March 2013 (UTC)