Talk:Aspect weaver/GA1

GA Review
The edit link for this section can be used to add comments to the review.''

Reviewer: Ironholds (talk) 13:24, 17 February 2010 (UTC)

Lede

 * "An aspect weaver is a metaprogramming utility designed to take instructions specified by aspects (isolated representations of a significant concepts in a program) in aspect-oriented languages in an effort to generate the final implementation code. " - repetition of "in"
 * ✅ Addressed -- Sh i r ik ( Questions or Comments? ) 18:21, 17 February 2010 (UTC)
 * What is "advice" and why is it italicised?
 * ✅ advice is the technical term for instructions to an aspect weaver. I have clarified that in the lede. Do you think this is ok? -- Sh i r ik ( Questions or Comments? ) 18:21, 17 February 2010 (UTC)

Motivation

 * "business-related concerns. Businesses are often concerned " -repetition
 * "often both an expense both money-wise and time-wise" - repetition
 * "Primary concerns for roadmaps for the adoption of new technologies tends" - repetition. Also, "concerns" is plural while "tends" is singular.
 * "This enforces that any existing object-oriented code will " - enforces/ensures.
 * ✅ all of the above -- Sh i r ik ( Questions or Comments? ) 18:32, 17 February 2010 (UTC)


 * Link aspect-orientated and object-orientated programming.
 * Did the OOP link. AOP is linked in the lede. Should it be linked here too? I thought things should only be linked the first time they are encountered. -- Sh i r ik ( Questions or Comments? ) 18:32, 17 February 2010 (UTC)
 * Nope. Take Court of Chancery for example; a reader cannot be expected, 2/3rds of the way down, to know what equity is. I appreciate that your article is smaller, but the same logic applies; having to scroll up and search for a term (or just use the search box, taking them away from the article) vexes people. Ironholds (talk) 21:03, 17 February 2010 (UTC)
 * ✅ Very logical, I was just unsure -- Sh i r ik ( Questions or Comments? ) 22:25, 17 February 2010 (UTC)

Implementation

 * Link "classes", "aspects", "bytecode". Remember, the audience is made up of laypeople.
 * All of these are linked in the lead. Again, should they be linked here as well, or only the first time they are encountered? -- Sh i r ik ( Questions or Comments? ) 18:36, 17 February 2010 (UTC)
 * See above. Ironholds (talk) 21:03, 17 February 2010 (UTC)
 * ✅ -- Sh i r ik ( Questions or Comments? ) 22:30, 17 February 2010 (UTC)
 * concepts? Surely "concept"
 * ✅ That segment was poorly worded anyway. I rephrased it, and the word "concept" disappeared. -- Sh i r ik ( Questions or Comments? ) 18:36, 17 February 2010 (UTC)