Talk:Dattorro industry scheme

Review
I think this is a nice article that summarizes the main aspects of the dattorro system. It is also supported by relevant citations. Future edits could expand the "Knob settings" section. Fdrc.Mtll (talk) 14:28, 7 July 2023 (UTC)

Review
The article is well done. I would probably merge the "delay line interpolation" and "block diagram" sections into the "theory sections" so that the meaning of D(t) is not split into two different sections (fractional delay and time dependency are split now). I agree with other reviewers that explaining in detail an intuitive idea of what are the orthogonal contributions of b, ff, fb and D(t) and what each contributes to the audio signal would be needed. The next step is.... animating the main image differently for each of the combination of knob settings. Imagine how cool it would be to see the moving tap actually moving. Magiwanders (talk) 14:46, 7 July 2023 (UTC)


 * I'll take it as an opportunity to learn desmos and try to do it in the future. Primoh (talk) 14:49, 7 July 2023 (UTC)
 * For simple animations it is very good! Magiwanders (talk) 14:57, 7 July 2023 (UTC)
 * I would also try to merge the two tables so that you have all the information needed to drive the dattorro scheme in one table, (as a reference you can specify those are two references merged I think) Magiwanders (talk) 14:51, 7 July 2023 (UTC)

Observations and suggestions for improvements
The following observations and suggestions for improvements were collected, following an expert review of the article within the Science, Technology, Society and Wikipedia course at the Politecnico di Milano, in July 2023. The wikipedia page on the Dattorro scheme is well written. As a suggestion I would add some comments on the amplitude and bias of the modulating signals (either sinusoid or low pass noise). In fact very often also the parameters "delay" and "depth" are indicated in the tables distinguishing the various audio effects. The "delay" in seconds can generally be interpreted as the fixed bias or offset of the delay modulating signal (e.g., sinusoid), while the "depth", again in seconds, is the amplitude of the delay modulating signal.

--Aandurro (talk) 11:05, 21 september 2023 (UTC)