Talk:Foster's reactance theorem/GA1

GA Review
The edit link for this section can be used to add comments to the review.''

Reviewer: Protonk (talk · contribs) 16:59, 4 October 2014 (UTC)

I'm always happy to review articles like this as I was an electrician in a past life (figuratively), so it's fun to see how little I knew about the underlying circuit theory. :) I've got a few comments below but I think the article is pretty close to GA, with just some work needed to make the explanation and characteristics of the theory a bit more clear.

style/layout

 * I think the lede could stand to be a little longer. It covers the basics and isn't required to be longer, but skips past the explanation and much of the history.
 * Done. SpinningSpark 01:12, 6 October 2014 (UTC)
 * Is it monotonic or strictly monotonic?
 * Strictly monotonic. SpinningSpark 01:12, 6 October 2014 (UTC)
 * "...completely determine the frequency characteristics of a Foster network." should we instead link to Frequency response here?
 * The frequency response article talks about inputs and outputs, that is, it is considering frequency response as the transfer function of a two-port network. An impedance function is a one-port.  While one can think of voltage and current as being input and output, all-in-all I think it would be confusing to link to that article. SpinningSpark 01:12, 6 October 2014 (UTC)

content

 * "Reactance is the imaginary part of the complex electrical impedance." I think this could benefit from a brief digression explaining that inductance and capacitance are both elements of impedance as well as the fact that the imaginary component is the one which is frequency dependent (as this will be important for the theorem). It may also help explain the importance of the system being lossless/passive.
 * Done first part. You are incorrect in thinking that the real part of impedance is not frequency dependent.  It can be frequency dependent even if all the resistors in the network have no frequency dependence.  For instance, the real part of the impedance of a resistor and capacitor in parallel is given by R/(1+(ωCR)2). SpinningSpark 23:05, 6 October 2014 (UTC)
 * "Foster's theorem applies equally to the admittance of a network..." This is neat (and the following sentence explains why we note it even though the bare application would be trivially true)
 * Doesn't seem to be anything actionable in that comment. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 23:05, 6 October 2014 (UTC)
 * Sorry about that. I originally had something else but reading a bit more decided against it. Protonk (talk) 23:34, 6 October 2014 (UTC)
 * The "explanation" section feels like a bit of throat clearing to get to the immitance form of the theorem. That's ok, so far as it goes, but it's not an explanation, per se. I think the clarity suffers a bit by inserting the application to distributed element capacitance between the assumptions and the link to admittance. We might be better off by taking some time to note the basics (impedance/resistance), making a statement of fosters theory for impedance then showing the dual nature of it as well as the similar outcome for admittance and finally stating the immitance version. The sentence on the discrete/distributed part could be dropped or moved someplace else.
 * I've moved the distributed element stuff down. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 23:20, 6 October 2014 (UTC)
 * We're also in the odd position of explaining the theory without specifying why the 'one port' bit is important.
 * I'm not sure I understand what your difficulty is here. One-port is merely a term of art.  It has to be a one-port because one cannot speak of the impedance of a multi-port.  One cannot even specify the impedance of one port of a multi-port without specifying what the other ports are doing.  An n-port is described by an nxn impedance matrix, not simply an impedance.  We can, of course, terminate all the other ports in a known impedance, but this merely reduces the network back to a one-port with a 1x1 impedance matrix, in other words just an impedance.  I'm not sure how to work any of that into the article, and I don't believe it would be beneficial.  It would be a bit like stating that a screw is a device for inserting into a threaded hole, and then launching a lengthy discussion on why it is only one hole. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 23:35, 6 October 2014 (UTC)
 * Ok, let me take another look. Protonk (talk) 02:25, 8 October 2014 (UTC)
 * "A consequence of Foster's theorem is that the poles and zeroes of any passive immittance function must alternate with increasing frequency." We're kinda stung here by the term "frequency" playing two roles. Do we mean that as frequency increases the poles and zeros must alternate or that they alternate more rapidly as frequency increases? Or both?
 * Done. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * "Two Foster networks that have identical poles and zeroes will be equivalent circuits in the sense that their immittance functions will be identical." Since these ciruits are by definition passive and lossless is explanation at the end of the sentence necessary? Or (alternately) could it be made more explicit by noting that the assumption proscribes non reactive components?
 * I'm not understanding the problem here. The sentence does not mention "passive and lossless", nor does it make an assumption. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * Well they're passive and lossless by virtue of being foster networks, so (if I'm understanding this, which as other comments have borne out may not be the case :) ) wouldn't two foster networks w/ identical poles and zeroes be equivalent circuits in every sense? Protonk (talk) 02:32, 8 October 2014 (UTC)
 * They are not necessarily topologically equivalent. For instance, these two networks,
 * Network, example(1).svgNetwork, example(1T).svg


 * are completely equivalent. They have the same poles and zeroes and the same impedance function, yet they are completely different topologically.  If that is where the issue lies then we can clarify that.  If it isn't then I have no idea what the problem is.
 * ....unless...this revolves round the scaling factor (stated in the article). If all the impedances of the first network are scaled by a factor of two for instance, making the component values C1, 1/2C1, and 2L2, then it is still equivalent to the second network in terms of having the same poles and zeroes and the shape of the impedance function remains the same.  However, the total impedance is now double what it was before.  We could say the networks are completely equivalent except in terms of how much they load the source. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 16:37, 8 October 2014 (UTC)
 * Ok. I think the question arises from the distinction between electrically equivalent and topologically identical. Which is to say if we mean Equivalent circuit, we can just link it without specifying immittance. I think the bit about the scaling factor could do with some clarification but it's relatively straightforward right now. Protonk (talk) 17:08, 8 October 2014 (UTC)
 * I would rather link to the article those diagrams came from which I wrote some time ago (never put up for GA if you have nothing better to do). The equivalent circuit article is not very focused and talks a lot about approximations which is not what we mean here at all. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 20:25, 8 October 2014 (UTC)
 * That works, thanks. Protonk (talk) 21:07, 8 October 2014 (UTC)

Thanks, Protonk (talk) 16:59, 4 October 2014 (UTC)
 * "A one-port passive immittance consisting of discrete elements (that is, not a distributed element circuit) can be represented as a rational function of s..." We jump right in here without explaining why impedance is described by a rational function.
 * This is a well known basic property of analysis. I have added a brief explanation. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * "Foster in his paper describes..." Probably better as "In his paper, Foster describes..."
 * Done. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * We go into a lot of detail in the Realization section but leave an explanation of how the different forms reduce to something solvable (for foster) only in the image captions. Would this be better expressed in the body of the article as well? I know we don't want to repeat ourselves too much but I think doing so will make the article a bit more clear.
 * I think it's fine as it is. The forms as described in the text are solutions, they do not need reducing.  The elements can take on any value, including zero and infinity in some cases, this does not need stating explicitly.  When explaining how this relates to poles and zeroes at zero and infinity, we need to refer to the relevant diagram.  This is easiest done in the caption of the relevant diagram.  The alternative is to give the diagrams figure numbers so they can be referenced.  Not everyone likes this; I have been criticised at FA by reviewers for this being "too textbook" and try not to do it any more. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * That's fair. Protonk (talk) 02:25, 8 October 2014 (UTC)
 * "This work was commercially important, large sums of money..." Vonnegut notwithstanding, this should be a semi-colon, no?
 * Done. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * "Amongst Cauer's many innovations was to extend..." probably "was the extension of"
 * Done. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)
 * "(the condition of being a Foster network is not a necessary and sufficient condition, for that, see positive-real function)" Is it necessary but not sufficient or neither?
 * Being a Foster network is by definition sufficient for realisability, but it is a long way from being necessary (a simple resistor is obviously realisable, and, equally obviously, is not Fosterite). The point being made here, I think, is that the iff condition is what Cauer was looking for.  Rewording to try and make that clear. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 17:05, 7 October 2014 (UTC)


 * Hi Protonk, thanks for reviewing. It may take me two or three sessions to go through all your comments.  Please be patient. <b style="background:#FAFAD2;color:#C08000">Spinning</b><b style="color:#4840A0">Spark</b> 01:12, 6 October 2014 (UTC)