Talk:Marshall McDonald/GA1

GA Review
The edit link for this section can be used to add comments to the review.''

Reviewer: MeegsC (talk · contribs) 17:31, 4 February 2021 (UTC)

I'll take this one! It may take me a few days to make my first comments. MeegsC (talk) 17:31, 4 February 2021 (UTC)
 * , thank you so much for choosing this article for GAR. I appreciate you taking the time to perform this review, and I look forward to your guidance and feedback, as I’ve long been a fan of your articles. Please let me know if you have any questions or need more information from me in the meantime! Thanks again! — West Virginian   (talk)  19:24, 4 February 2021 (UTC)
 * , thank you for this incredibly thorough, comprehensive, and thoughtful review for GA! I’ll be addressing your comments as soon as I have a moment within the next few days. Thank you again! — West Virginian   (talk)  12:49, 9 February 2021 (UTC)

Overall, this is a nice article about an interesting man. It's already in pretty good shape. That said, there are a few things to address:

A writing instructor I once had told us that studies show the average reader loses 5% comprehension for every word over 25 in a sentence. So be conscious of longer sentences, and shorten them where possible. (You do pretty well here, though there are a few 37-40 word sentences. That's a 75% comprehension loss for your average readers. Given that it's only the occasional sentence - and that we're not dealing with terribly complex ideas - you're probably okay with most of them.)

If you'll strike things out as you deal with them, I'll know what you've had a chance to fix.
 * , I'm working to address your comments and hoping to finish today! I'll follow your instructions and will strike out as I address each comment. Thank you so much for this incredibly thorough and thoughtful review! -- West Virginian   (talk)  15:36, 13 February 2021 (UTC)

Lede

 * "Born in 1835 in Romney, Virginia (present-day West Virginia), McDonald was the son of a military officer and lawyer Angus William McDonald and his wife, Leacy Anne Naylor." This reads awkwardly. I'd suggest moving the clause about his father's job: e.g. "Born in 1835 in Romney, Virginia (present-day West Virginia), McDonald was the son of Angus William McDonald, a military officer and lawyer, and his wife, Leacy Anne Naylor."
 * "Following the war in 1865, McDonald returned to the Virginia Military Institute where he was appointed a professor with the rank of colonel instructing and serving as chair of the subjects of chemistry, geology, mineralogy, and metallurgy." There should be a comma after "colonel". And you could probably start the next sentence with "He" rather than McDonald to reduce the name repetition a bit.
 * Was it in 1875, or by 1875 that he became interested in fish farming? Seems pretty amazing that he'd be named an administrator the very first year he was interested!
 * I've changed this to: "By 1875, McDonald was involved in fish farming and became the administrator of the Virginia state fish hatchery..." -- West Virginian   (talk)  15:51, 13 February 2021 (UTC)

Early life and education

 * "Following the death of his mother, McDonald's father sold the Naylor family's log dwelling in 1849..." There's a misplaced modifier here; I'm assuming it was Leacy Anne and not McDonald's father's mother that died.
 * I've changed this sentence to: "Following the death of McDonald's mother Leacy Anne, his father sold the Naylor family's log dwelling..." -- West Virginian   (talk)  15:50, 13 February 2021 (UTC)


 * "McDonald and his family were still residing in Romney at the time of the 1850 United States Census." Which McDonald are we talking about here -- Angus or Marshall? I've lost track. If Marshall, then does "his family" include his father, or has Angus already moved? The last three sentences of this section are confusing.
 * I've rephrased this to: "McDonald, his father, and his siblings were still residing in Romney..." -- West Virginian   (talk)  15:50, 13 February 2021 (UTC)

Education and early academic career

 * "Fall 1860..." Fall should be lower case.

Military career in the American Civil War

 * "He then served as inspector general of the staff..." Is "of" correct here? Or should it be "on"?
 * I've changed this to "on." -- West Virginian   (talk)  15:59, 13 February 2021 (UTC)


 * "While serving as chief engineer under Pemberton, the Union Army..." Another misplaced modifier; the Union Army was never a chief engineer. ;)
 * I've changed this to: "While he was serving as chief engineer under Pemberton, the Union Army took McDonald as a prisoner of war..." -- West Virginian   (talk)  15:59, 13 February 2021 (UTC)


 * Sources seem to indicate that McDonald was wounded in battle; after all, his student refers to him "pointing with his crutch". Was he? You make no mention here.
 * I was not sure how to handle this here as I was not able to find specific information stating whether and how he was wounded in battle. Any guidance you could provide would be extremely appreciated! -- West Virginian   (talk)  15:59, 13 February 2021 (UTC)


 * "McDonald was promoted to the rank of major in command of engineers on the staff of General Braxton Bragg and was to be promoted to the ranks of colonel and brigadier general when the war ended." Does that mean he wasn't promoted because the war ended too soon? Or that he was promoted during the course of the war? It's entirely unclear. If the later, I'd suggest "McDonald was promoted to the rank of major in command of engineers on the staff of General Braxton Bragg. By the end of the war he had been promoted to the ranks of colonel and brigadier general."
 * I've changed this to your suggested rephrasing as it best represents the sources. -- West Virginian   (talk)  15:59, 13 February 2021 (UTC)


 * Did Angus McDonald die in battle, or of wounds or disease, or...? I'm not quite sure why his details are included here, but if you're going to include them, include ALL of them!
 * I've removed mention of his father's death altogether. He was elderly and living in Richmond when he died, so it was unrelated to the war. -- West Virginian   (talk)  15:59, 13 February 2021 (UTC)

Return to VMI

 * "Following the war in 1865, McDonald returned to the Virginia Military Institute where he was appointed a professor with the rank of colonel instructing and serving as chair of the subjects of chemistry, geology, mineralogy, and metallurgy." There should (at least) be a comma after colonel. In fact, I'd suggest a period, followed by "He served as both instructor and chair..." (This is one of those longer sentences I mentioned at the top.)
 * "The Board of Directors appointed McDonald to replace Colonel Gilham, (who had been appointed to replace George Washington Custis Lee the previous year), as chair of the subjects of chemistry, mineralogy, and geology." This seems to be a repetition of much of the previous sentence. Is it important who he replaced? If so, then remove the info about the chair position from the previous sentence. If not, then delete this sentence.
 * I've deleted this sentence accordingly. -- West Virginian   (talk)  16:07, 13 February 2021 (UTC)


 * "Upon his return to the Virginia Military Institute, McDonald established the institution's first museum." We already know (based on the section we're in) that it's upon his return, so that clause can be removed. Of more interest is what is contained in the museum - why did he create it?
 * I've removed the opening clause, but unfortunately I cannot find more sourcing about what the museum contained. Let me know if you recommend for me to delete this mention altogether. -- West Virginian   (talk)  16:12, 13 February 2021 (UTC)
 * I found this website about the museum. Interestingly, it says Superintendent Smith started the museum in 1856. If it doesn't add anything, I'd just say something like "During his tenure, McDonald established the institution's first museum."


 * "In 1875, McDonald developed an interest in fish farming..." same query as above (in the lede section).
 * "He was appointed as the sole Fish Commissioner of Virginia shortly thereafter." The footnotes after this sentence aren't in order.
 * "It was during his tenure in this position that McDonald invented the fish ladder that was named for him." Was it while he was here? Or at the US Fish Commission? Because it's mentioned again in the "Fish hatching innovations" in that section. If it was here, then informaton about that invention should be moved here.
 * I've consolidated all the ladder content in this section. -- West Virginian   (talk)  16:22, 13 February 2021 (UTC)


 * "In 1877, Virginia commissioned McDonald to conduct a survey of mineral resources within the James River basin, reporting and to report his findings to the Virginia General Assembly in 1879." I'm assuming that he was to report his results?
 * I've changed to recommended rephrasing. -- West Virginian   (talk)  16:26, 13 February 2021 (UTC)


 * "McDonald continued to instruct at the Virginia Military Institute until 1879, when his former professor, Spencer Fullerton Baird, offered him a position with the United States Commission of Fish and Fisheries." Again, footnotes out of order. And was Baird ever his professor? He never taught at VMI.
 * I've corrected the order of the footnotes and have deleted the mention of him being a former professor of McDonald's. -- West Virginian   (talk)  16:26, 13 February 2021 (UTC)

I'll finish this up after lunch! MeegsC (talk) 13:39, 7 February 2021 (UTC)
 * "McDonald accepted and submitted his resignation from the Virginia commission to Governor Fitzhugh Lee." Comma after accepted.
 * Sorry for the delay; it was a long lunch!! XD
 * , no apologies necessary! I apologize to you for not being able to address your thorough comments sooner! Thank you again! -- West Virginian   (talk)  16:27, 13 February 2021 (UTC)

United States Fish Commission

 * "McDonald was appointed to an assistant's position within the United States Fish Commission where he was a special agent under Baird and responsible..." Commas after commission and Baird, and you can lose the "and".
 * When you say he was "responsible for the distribution of young fishes and food fishes", what does that mean? To whom did he distribute them? Other hatcheries? Rivers? Restaurants?
 * I've rephrased this as: "McDonald was responsible for the distribution of "young fishes" and of "food-fishes" to state fisheries..." -- West Virginian   (talk)  16:36, 13 February 2021 (UTC)


 * "...because of the breadth of his experience, organizational and leadership abilities, and his sense of duty and ..." I think there should be a "his" in front of "organizational" here.
 * "McDonald was viewed as one of the "most accomplished" fish culturists in the United States at the time of his appointment." By whom? The quote needs to be attributed.
 * I've rephrased this as: "According to William A. Bruette in Field and Stream, McDonald was one of the most accomplished fish culturists in the United States at the time of his appointment." -- West Virginian   (talk)  16:40, 13 February 2021 (UTC)


 * It may just be personal preference (and feel free to ignore this one), but "designed and invented" sounds more typical than "invented and designed".
 * What was an "automatic hatching jar"? What did it do? Why was it such a revolutionary invention? A brief description would be great here (a la your explanation of the tide box).
 * I added a sentence describing what the jars do based on a new reference from McDonald. -- West Virginian   (talk)  18:50, 13 February 2021 (UTC)


 * The vast production and distribution of fish eggs by the Fish Commission was made possible through the utilization of this tidal apparatus. " By using this apparatus, Its use made the process of hatching eggs was made cheaper and increased the commission's fish farming output capacity." A few tweaks to tighten the wording and make it slightly less stilted.
 * "Prior to his appointment as Fish Commissioner, McDonald was awarded gold medals and diplomas from international fishery exhibitions in Berlin and London and a silver medal from the Société d’Acclimation in Paris for his inventions and improvements in the field of fish farming." Comma after London. Maybe "Early in his career at the Fish Commission..." rather than "Prior to his appointment..." It felt a bit odd to have this tacked on at the end of the section, given that he won these awards so early in his career there. Could this be worked into the first paragraph, with his subsequent commission moved into a second paragraph? Not a deal-killer by any means; it just felt a bit "stuck-on" where it is now.
 * I rephrased the beginning per your recommendation, but had wanted to keep this here so that all the awards and honors were together in one paragraph. Take another look and let me know if this would do or if it requires further reorganization. Thanks again! -- West Virginian   (talk)  18:50, 13 February 2021 (UTC)

Later life and death

 * Maybe "By the time" instead of "At the time" at the start of the first sentence. This SAR sentence is a bit abrupt—and most of the rest of the material about why and how he applied is several sections below in the Geneology section. I think it would read better if you reworked this to incorporate all of that information in the same section. Maybe explain about what it is and why he applied and what the results were. Also odd was the sudden introduction of a wife and dead child who then aren't "introduced" for several more sections.
 * I modified this sentence to: "By 1890, McDonald was residing at 1514 R Street..." -- West Virginian   (talk)  18:58, 13 February 2021 (UTC)


 * Maybe say "He added..." or some such before the second Charles Hallock quote. Right now, it looks a bit odd to have a floating quote out there, not connected to the other one.
 * There's a lot of "McDonalds" in this paragraph. You could probably start the third sentence with "His condition deteriorated" to mix things up a bit.

The last two sections read fine, but I wonder whether it might not be better to weave this information into the flow of his life at least slightly further up in the article—at least introducing them prior to mentioning them.
 * I wasn't sure where to move these to, so I've moved them down to the personal life section. Let me know if this should be moved elsewhere. -- West Virginian   (talk)  18:58, 13 February 2021 (UTC)
 * This looks better! MeegsC (talk) 20:32, 13 February 2021 (UTC)
 * Earwig's copyright violation tool doesn't throw up any significant issues. The pictures all have appropriate licenses, and are appropriate to the article. I'll put the review on hold for a week to give you a chance to address these issues. I'll keep an eye on this, but feel free to ping me if you have any questions! MeegsC (talk) 21:18, 8 February 2021 (UTC)
 * , I've finished addressing each of your comments. Thank you for your incredibly thorough and comprehensive review of this article and for improving it through your review! -- West Virginian   (talk)  18:59, 13 February 2021 (UTC)
 * this looks great! I'm happy to give this a GA plus! MeegsC (talk) 20:32, 13 February 2021 (UTC)
 * , thank you so much! And I also added "during his tenure" to the sentence re: the museum. It has been a pleasure working with you throughout this process and look forward to working with you again in the future! Thanks again! -- West Virginian   (talk)  20:33, 13 February 2021 (UTC)