Talk:Nun danket all und bringet Ehr/GA1

GA Review
The edit link for this section can be used to add comments to the review.''

Reviewer: The Rambling Man (talk · contribs) 16:10, 16 August 2019 (UTC)

Comments Otherwise not much more to add at this stage. I'll put the article on hold. The Rambling Man (Staying alivesince 2005!) 15:13, 18 August 2019 (UTC)
 * There's a Category:Hymns by century super-category, any use in popping a suitable one of those on this article?
 * thank you, added --GA
 * Given that a lot of the article is the text of the hymn, I think one para in the lead would be suitable rather than the two short paras you currently have.
 * let me first see if it will grow --GA
 * It hasn't. You have a single-sentence para, and a two-sentence para.  Merge!  The Rambling Man (Staying alive since 2005!) 16:06, 19 August 2019 (UTC)
 * "Wisdom of Sirach 50:22–24, " I think I'd prefer "Wisdom of Sirach " because I, for one, have never heard of that chapter.
 * you mean "of that book"? - any way to still have the normal display, without brackets and "ch"? --GA
 * "music was an image of divine bliss" if this is a quote, quote it, if it's not, it doesn't seem particularly neutral.
 * I added the German quote, and changed divine to heavenly (himmlisch). --GA
 * "The hymn was sung to conclude..." avoid single-sentence paras.
 * I hear you, but this is not connected in any way to what comes before nor after. --GA
 * Consider linking hymnal.
 * Well, done, but really? --GA
 * Yep, I have literally never said the word "hymnal" in my entire life. The Rambling Man (Staying alive since 2005!) 16:06, 19 August 2019 (UTC)
 * Is it conventional to replicate all the text of the whole hymn in such articles? Especially considering this is English language Wikipedia and that's a whole bunch of old German which is basically inaccessible to all but a few of our readers...
 * It is so in many I know, and the more often a hymn gets sung, the more so. Compare "Now Thank We All Our God". --GA
 * If so, there's an almighty amount of white space now, would you consider dividing it into columns?
 * Let me first look for a translation. --GA
 * I found something for some stanzas,, will apply after rehearsal or tomorrow. --Gerda Arendt (talk) 16:52, 19 August 2019 (UTC)
 * I'll wait! The Rambling Man (Staying alive since 2005!) 16:06, 19 August 2019 (UTC)
 * Added what found (1-2-3-6-8) --Gerda Arendt (talk) 21:30, 19 August 2019 (UTC)
 * "Johann Crüger published the hymn in the (lost) 1647 edition of his hymnal Praxis pietatis melica, " you said that already, but this is the first time I recall you saying the 1647 edition was (lost).
 * I say it now the first time, and drop the second, hoping people will remember. --Gerda Arendt (talk) 14:56, 19 August 2019 (UTC)
 * It's pure ignorance, but I'm struggling to see the relevance of the final para of the article (starting "Hugo Distler composed..."), how do these facts relate to the article? I imagine if I'm struggling, others may too.
 * It's standard to say which composers used a hymn in what pieces, compare Psalm 150 and the hymn linked above, where "Musical settings" is a separate header. I'll see if I can find more. --Gerda Arendt (talk) 14:56, 19 August 2019 (UTC)
 * Thank you for looking! Nominated on my mom's birthday, - a song present at family baptisms and anniversaries, and probably at many families'. --Gerda Arendt (talk) 14:56, 19 August 2019 (UTC)
 * No problem. It looks like it's been waiting a while.  I added a few responses.  Let me know when you think you're done. The Rambling Man (Staying alive since 2005!) 16:06, 19 August 2019 (UTC)
 * TRM, I added a bit. --Gerda Arendt (talk) 22:18, 19 August 2019 (UTC)
 * I'll take a look tomorrow. The Rambling Man (Staying alive since 2005!) 22:20, 19 August 2019 (UTC)

The Rambling Man (Staying alive since 2005!) 07:31, 22 August 2019 (UTC)
 * Lead is still two paras. The first sentence of the lead has too many run-ons.
 * "Charles S. Terry" is linked to a dab page.
 * " hymnal Evangelisches Gesangbuch'." spare apostrophe there.
 * ready? --Gerda Arendt (talk) 08:49, 22 August 2019 (UTC)
 * Just need to fill in the last few refs suitably, access dates and/or publication dates please. The Rambling Man (Staying alive since 2005!) 08:50, 22 August 2019 (UTC)
 * tomorrow perhaps, off for today --Gerda Arendt (talk) 08:53, 22 August 2019 (UTC)
 * No rush. The Rambling Man (Staying alive since 2005!) 09:04, 22 August 2019 (UTC)
 * I got a minute, but don't quite get what you mean. Do you think the IMSLP should have a date? And which, - year of publication. Accessdate? Would I add it to the template? --Gerda Arendt (talk) 14:24, 22 August 2019 (UTC)
 * Yeah, you know, we either put the publication date or an accessdate, sometimes both, for web-based resources. It's anomalous for you not to have that information on those references while you do for the others. The Rambling Man (Staying alive since 2005!) 14:29, 22 August 2019 (UTC)
 * And as you've done for the other PDF refs, we usually use, right? The Rambling Man (Staying alive since 2005!) 14:32, 22 August 2019 (UTC)
 * No, I don't add "format=pdf", the cite template does it. However, the IMSLP are simply that (different) template. It's not a PDF. No idea how to add a a date. --Gerda Arendt (talk) 14:47, 22 August 2019 (UTC)
 * Oh, okay, marvellous. I suppose the insistence to use the IMSLP template means that the references will not format comprehensively, which is a shame.  I don't understand why such templates exist when they don't offer the required parameters.  But GAN doesn't insist on professionally formatted refs I suppose, so I'll just have to suck it in.  I'll take another look through later before offering a final opinion.  The Rambling Man (Staying alive since 2005!) 15:05, 22 August 2019 (UTC)
 * I hate shame ;) - I can format the thing like other references, if that's better. All we want to reference is that those pieces exist, but long live formality. --Gerda Arendt (talk) 16:00, 22 August 2019 (UTC)