Talk:Rust (programming language)/GA1

GA Review
The edit link for this section can be used to add comments to the review.''

Reviewer: Hawkeye7 (talk · contribs) 03:53, 14 July 2022 (UTC)

Picking this one up. Review to follow. Hawkeye7  (discuss)  03:53, 14 July 2022 (UTC)

Comments
Article looks in reasonable shape. Some work required.
 * Lead


 * Last paragraph of the lead is not covered in the body. I would move all but the first sentence into the body.
 * ✅. 0x Deadbeef


 * Early origins (2006–2012):
 * Combine the single sentence paragraphs into a single paragraph. (MOS:PARA)
 * ✅. 0x Deadbeef
 * Link Mozilla
 * ✅. 0x Deadbeef


 * Evolution (2013–2019)
 * "Rust's object system, used for object-oriented programming" Hang on. You said in the lead that it was a functional language, not an object oriented one.
 * ✅ by rewording it to type system. 0x Deadbeef
 * Combine the first two and last two paragraphs.
 * ✅. 0x Deadbeef
 * Link C++
 * ✅. 0x Deadbeef


 * Mozilla Layoffs and Rust Foundation (2020–present)
 * Combine the first two and last two paragraphs.
 * ✅. 0x Deadbeef
 * The last two also need combining or folding in, but also require a bridge to avoid to sentences running starting with "On ..."
 * ✅. 0x Deadbeef


 * Hello, World program
 * Should we mention that the bang indicates a macro instead of a function?
 * ✅. 0x Deadbeef


 * Syntax and semantics
 * Entire section is unreferenced. References are required here.
 * ✅. 0x Deadbeef 14:37, 14 July 2022 (UTC)


 * Keywords and control flow
 * Might as well mention comments here as well, since you're using them
 * ✅. 0x Deadbeef


 * Expression blocks
 * "if the semicolon is omitted, the last expression in the function will be used as the return value" The last expression, or the value of the last expression?
 * ✅. 0x Deadbeef


 * Types
 * For inferred types, can the table tell us what type is inferred?
 * ✅ by explaining what (inferred type) means in the table. 0x Deadbeef
 * Link immutable object, syntactic sugar
 * ✅. 0x Deadbeef


 * Memory management
 * Citation required.
 * ✅. 0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Ownership
 * Citation required.
 * ✅ - removed the section because it is a duplicate. 0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Types and polymorphism
 * Citation required.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Cargo
 * Citation required.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)


 * IDE support
 * Citation required.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Performance
 * Merge sentences into one paragraph.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Adoption
 * Citation required.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Components
 * Can we describe the standard library?
 * I cannot find reliable sources that can provide a good summary of the standard library. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)
 * (already cited once in the article) says:
 * "Sadly, though, Rust has a fairly tight standard library. As with regular expressions, another area with relatively minimalist support is handling command-line arguments." (p. 71)
 * "Rust's standard library is comparatively slim. It excludes numeric types that are often available within other languages. These include: Many mathematical objects for working with rational numbers and complex numbers; arbitrary-size integers and arbitrary-precision floating-point numbers ... fixed-point decimal numbers for working with currencies" (p.43)
 * "Rust's standard library tends to lack many things that other languages provide, like random number generators and regular expression support. That means it's common to incorporate third-party crates into your project." (p.67)
 * I think it's alright to cite a primary source as well, i.e. . And maybe it's worth noting that you can exclude std if desired. Ovinus (talk) 18:50, 14 July 2022 (UTC)
 * Usually for things like programming languages and technology, primary sources are OK. Theres a guideline somewhere, I forget where it is, but I know the conesnsus is that its less strict then living people and historical events. Rlink2 (talk) 21:34, 14 July 2022 (UTC)
 * Web browsers and services
 * Citation required.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)


 * Rust Foundation
 * Citation required.
 * ✅ and fixed pov. <span style="font-family:Iosevka,monospace">0x Deadbeef 14:37, 14 July 2022 (UTC)


 * Notes
 * Still require references.
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 14:37, 14 July 2022 (UTC)


 * References
 * fn 1, 104 - need access date
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef
 * fn 1, 6, 7, 8, 12, 24, 38, 40, 42, 66, 69, 75, 85, 95, 96, 102, - need publisher
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)
 * fn 34 - needs degree + university
 * ✅. <span style="font-family:Iosevka,monospace">0x Deadbeef

GA review – see WP:WIAGA for criteria


 * 1) Is it well written?
 * A. The prose is clear and concise, and the spelling and grammar are correct:
 * B. It complies with the manual of style guidelines for lead sections, layout, words to watch, fiction, and list incorporation:
 * 1) Is it verifiable with no original research?
 * A. It contains a list of all references (sources of information), presented in accordance with the layout style guideline:
 * B. All in-line citations are from reliable sources, including those for direct quotations, statistics, published opinion, counter-intuitive or controversial statements that are challenged or likely to be challenged, and contentious material relating to living persons&mdash;science-based articles should follow the scientific citation guidelines:
 * C. It contains no original research:
 * D. It contains no copyright violations nor plagiarism:
 * 1) Is it broad in its coverage?
 * A. It addresses the main aspects of the topic:
 * B. It stays focused on the topic without going into unnecessary detail (see summary style):
 * 1) Is it neutral?
 * It represents viewpoints fairly and without editorial bias, giving due weight to each:
 * 1) Is it stable?
 * It does not change significantly from day to day because of an ongoing edit war or content dispute:
 * 1) Is it illustrated, if possible, by images?
 * A. Images are tagged with their copyright status, and valid non-free use rationales are provided for non-free content:
 * B. Images are relevant to the topic, and have suitable captions:
 * 1) Overall:
 * Pass or Fail:
 * Quite good. Putting on hold pending changes.
 * Thank you, User:Hawkeye7, I suppose the use of WP:ABOUTSELF sources in the technical sections would not prevent it from passing the GA? Or is there a need to reference the book "The Rust Programming Language (Covers Rust 2018)" in addition? <span style="font-family:Iosevka,monospace">0x Deadbeef 06:43, 14 July 2022 (UTC)
 * WP:ABOUTSELF only applies to biographies. Citing a book about the Rust programming language is precisely what is required. Hawkeye7   (discuss)  08:07, 14 July 2022 (UTC)
 * I've responded to all points raised above, please take another look when you have time :) Thanks again. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)
 * 1) Is it illustrated, if possible, by images?
 * A. Images are tagged with their copyright status, and valid non-free use rationales are provided for non-free content:
 * B. Images are relevant to the topic, and have suitable captions:
 * 1) Overall:
 * Pass or Fail:
 * Quite good. Putting on hold pending changes.
 * Thank you, User:Hawkeye7, I suppose the use of WP:ABOUTSELF sources in the technical sections would not prevent it from passing the GA? Or is there a need to reference the book "The Rust Programming Language (Covers Rust 2018)" in addition? <span style="font-family:Iosevka,monospace">0x Deadbeef 06:43, 14 July 2022 (UTC)
 * WP:ABOUTSELF only applies to biographies. Citing a book about the Rust programming language is precisely what is required. Hawkeye7   (discuss)  08:07, 14 July 2022 (UTC)
 * I've responded to all points raised above, please take another look when you have time :) Thanks again. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)
 * Thank you, User:Hawkeye7, I suppose the use of WP:ABOUTSELF sources in the technical sections would not prevent it from passing the GA? Or is there a need to reference the book "The Rust Programming Language (Covers Rust 2018)" in addition? <span style="font-family:Iosevka,monospace">0x Deadbeef 06:43, 14 July 2022 (UTC)
 * WP:ABOUTSELF only applies to biographies. Citing a book about the Rust programming language is precisely what is required. Hawkeye7   (discuss)  08:07, 14 July 2022 (UTC)
 * I've responded to all points raised above, please take another look when you have time :) Thanks again. <span style="font-family:Iosevka,monospace">0x Deadbeef 17:39, 14 July 2022 (UTC)

Thanks for the review! Caleb Stanford (talk) 16:13, 14 July 2022 (UTC)

All good for GA. Great work. I made some (very) minor changes to resolve a disambig, suppress a warning (which most people would never see), reformat an ISBN (cosmetic) and reference an unreferenced sentence. There are a quite a few duplicated links; I wasn't sure how you feel about these. If you take it to FAC, anticipate some probing questions about your sources. A couple of suggestions, largely from my curiosity:
 * The example in the macros section does not show you how one is written
 * The standard library stands out as a possible area for expansion. Footnote 1 implies that it is anything but.
 * Note 5 does not say anything. Suggest removing it or folding it into a footnote.
 * Hawkeye7  (discuss)  21:51, 14 July 2022 (UTC)