Talk:Shibl al-Dawla Nasr/GA1

GA Review
The edit link for this section can be used to add comments to the review.''

Reviewer: Cplakidas (talk · contribs) 17:09, 27 December 2022 (UTC)

Will review in the next few days. Constantine  ✍  17:09, 27 December 2022 (UTC)
 * GA review (see here for what the criteria are, and here for what they are not)

The usual fine job, easy to read, comprehensive, and well referenced. Only some minor comments/suggestions:
 * 1) It is reasonably well written.
 * a (prose, spelling, and grammar): b (MoS for lead, layout, word choice, fiction, and lists):
 * 1) It is factually accurate and verifiable.
 * a (reference section): b (citations to reliable sources):  c (OR):  d (copyvio and plagiarism):
 * 1) It is broad in its coverage.
 * a (major aspects): b (focused):
 * 1) It follows the neutral point of view policy.
 * Fair representation without bias:
 * 1) It is stable.
 * No edit wars, etc.:
 * 1) It is illustrated by images and other media, where possible and appropriate.
 * a (images are tagged and non-free content have non-free use rationales): b (appropriate use with suitable captions):
 * 1) Overall:
 * Pass/Fail:
 * 1) It is illustrated by images and other media, where possible and appropriate.
 * a (images are tagged and non-free content have non-free use rationales): b (appropriate use with suitable captions):
 * 1) Overall:
 * Pass/Fail:
 * 1) Overall:
 * Pass/Fail:
 * Made some copyedits for minor style issues, links, etc. as more expedient.
 * Lede says his reign began in 1029/30, but infobox has this as May 1029 when the battle of al-Uqhuwana happened, and the main article says 'In the aftermath of al-Uqhuwana, Nasr and Thimal ruled Aleppo jointly, ' which indicates sometime (soon?) after May 1029, but not 1030. I realize the latter refers to his ouster of Thimal, but this may not be so obvious. Can we reconcile these somehow?
 * Clarified the confusion. Al Ameer (talk) 17:03, 1 January 2023 (UTC)


 * It may not be obvious to a reader quite who the 'Bedouin allies' were. Perhaps smth like 'In 1029, he supported his fellow Bedouin ally...'?
 * Done. Al Ameer (talk) 17:03, 1 January 2023 (UTC)


 * is in effect repeated with more detail later on at, so it is rather redundant.
 * Good point, done. Al Ameer (talk) 17:03, 1 January 2023 (UTC)


 * Close repetition:
 * Agree, done. Al Ameer (talk) 17:03, 1 January 2023 (UTC)


 * 'near Iraq' is odd: is modern or ancient Iraq meant, and what exactly does 'near' mean (and why is this important)?
 * Revised, but let me know if it works, or if Iraq should be defined. Al Ameer (talk) 17:03, 1 January 2023 (UTC)
 * Looks good. Constantine  ✍  16:38, 7 January 2023 (UTC)


 * unless a different Yahya of Antioch is meant, Yahya lived in the 11th century.
 * Correct! Al Ameer (talk) 17:03, 1 January 2023 (UTC)


 * Do we know when Nasr first received his title of 'Shibl al-Dawla'?
 * Could not find this in the sources, including Bianquis 1989 (which is not cited in the article but should be) and Zakkar. Al Ameer (talk) 17:03, 1 January 2023 (UTC)
 * That's fine, I am sure that if you cross upon it, it will be added. Constantine  ✍  16:38, 7 January 2023 (UTC)


 * Be consistent in the transliteration of Arabic terms, either strict transliteration with diacritics (e.g. khāṣtuʾl-imām) or without (e.g. ahdath); IIRC, MOS recommends the latter
 * Done.


 * add that he was the vizier?
 * Done. Al Ameer (talk) 17:03, 1 January 2023 (UTC)


 * In the infobox, add the period in 1029-30 where he shared rule with Thimal
 * Added in parentheses; let me know if this works, or if better to create another 'term' parameter. Al Ameer (talk) 17:03, 1 January 2023 (UTC)
 * Perfect. Adapted the succession box as well. Constantine  ✍  16:38, 7 January 2023 (UTC)


 * Chapter title and ISBN for Smoor?
 * Done. Al Ameer (talk) 17:03, 1 January 2023 (UTC)

Once these are addressed, I will have another look. Constantine  ✍  10:59, 31 December 2022 (UTC)
 * Thanks for taking time to review this, and for your suggestions. Other than the above, let me know if anything else.
 * Note: I only recently came across Bianquis 1989 and will begin to mine this valuable source for information about Nasr, which is found in summary form in Bianquis's EI2 entry on the Mirdasids, in the coming weeks. Al Ameer (talk) 17:03, 1 January 2023 (UTC)
 * I have now re-reviewed the article. My comments are addressed, and I could find nothing more to complain about ;). I am happy to pass this now, and I expect to be seeing it at ACR or FA at some point, once Bianquis has been incorporated. Constantine  ✍  16:38, 7 January 2023 (UTC)
 * Thank you once again. And that is indeed the plan. Al Ameer (talk) 05:07, 8 January 2023 (UTC)