Template talk:Edit summary field

Template-protected edit request on 24 April 2021
Hello! Could someone please copy/paste the sandbox back in here? (Somewhat of a pull request for templates.) See the sandbox for a demonstration. This changes the style to the new visual style (VisualEditor & 2017 wikitext editor).

In other words (x to y), please change: 

To:  Describe what you changed

Thank you! Tol &#124; Talk &#124; Contribs 17:02, 24 April 2021 (UTC)
 * not sure it makes sense to do this - should we be encouraging or assuming VE use among newbies? (I don't think so...) Elli (talk &#124; contribs) 19:13, 26 April 2021 (UTC)
 * @Elli: Ah, my mistake. (There are so many editors it gets confusing.) I believe the default is the 2010 WikiEditor? I use the 2017 wikitext editor (the one inside VisualEditor) and mistakenly thought it was the default. Regardless, the box still looks wrong; I'll get it in line with the 2010 editor and fix this request. Tol &#124; Talk &#124; Contribs 19:43, 26 April 2021 (UTC)


 * Alright; I've updated the sandbox — can you take a look here and let me know what you think? Tol &#124; Talk &#124; Contribs 20:00, 26 April 2021 (UTC)
 * Yes check.svg Done Elli (talk &#124; contribs) 20:19, 26 April 2021 (UTC)
 * Thanks! Tol &#124; Talk &#124; Contribs 20:43, 26 April 2021 (UTC)
 * Broken; reverted. Try again. Mathglot (talk) 18:44, 27 May 2021 (UTC)
 * uh, what was broken exactly? I did test it before implementing and didn't see an issue... Elli (talk &#124; contribs) 22:55, 27 May 2021 (UTC)
 * This. Mathglot (talk) 00:42, 28 May 2021 (UTC) Señallll.png
 * that's not what it looks like on my end, there's no reason this should be broken. Elli (talk &#124; contribs) 00:45, 28 May 2021 (UTC)
 * Hm.. that's from mobile; let me get to a computer, and I'll see if it's better there. I'll check a few browsers, as well. Mathglot (talk) 00:48, 28 May 2021 (UTC)

, Ran these tests while not logged in, to make sure it's not something in my common css or js.

Not sure what the next step is; maybe grab the page source of the element and dump it here, so we can look at the html? Can you try some tests, while not logged in? Mathglot (talk) 01:46, 28 May 2021 (UTC)
 * Elli, I edited the sandbox as a temporary test, so it contained just the line . What I see there, is an empty input box, flush left, about 3/4 of the width of the page, with the word 'Before' above it, and the word 'After' below it. This test is visible only in rev. 1025527960 of the The edit-summary field/sandbox. Can you tell me what you see there?  Afaict, it is that template that generates the input box that was visible before your version, and that disappeared with your edit.
 * When I look at the diff of your version of the template, I can see that you removed the line of code that contains template Inputbox. So, I don't see how it could work on your system without that line. Is it possible that you have an old version of the template cached? What happens if you test your version again, after purging the page? Mathglot (talk) 02:51, 28 May 2021 (UTC)
 * The temporary test in the sandbox shows the same for me as it does for you.
 * When I try the old version in a private window, it indeed doesn't show the box. However, looking at the code with inspect element shows the exact same thing -  - in both situations. I guess I might have a custom style-sheet affecting mw-ui-input? (though I don't have an idea why that would be the case) This doesn't appear to be related to caching. Elli (talk &#124; contribs) 03:35, 28 May 2021 (UTC)
 * Here's what I see when comparing the generated Html of your version, the version before it, and the sandbox test version in rev. 1025527960:
 * Here's what I see when comparing the generated Html of your version, the version before it, and the sandbox test version in rev. 1025527960:

Html of sandbox revision 1025527960 contains the following code:

this generates the following Html on the rendered page: Before &#160;    After

Andrybak's revision 986882974 of April 26 has the Inputbox template as well, and generates this: (Briefly describe your changes) &#160;

Elli's revision 1020034884 does not contain template Inputbox; it generates this:

(Briefly describe your changes)


 * So, if you're seeing an input box, I don't understand how that's happening, because your version dropped the Input box template, and seems to be trying to generate the same thing using an Html div with class "mw-ui-input", but a) it doesn't seem to be working, at least, not for everybody; and b) what was the reason for replacing the Inputbox template with direct Html? Mathglot (talk) 03:41, 28 May 2021 (UTC)
 * that indeed seems to be the case. I think the only difference here is if the class "mw-ui-input" properly renders an inputbox.
 * The reason I did so is described in the original edit request - to match the way the edit summary box actually looks in the modern editor. I didn't write the code - I copied what was in the edit request, tested it (apparently not as thoroughly as it should've been, but I had no reason to expect that it wouldn't work), then implemented it. Elli (talk &#124; contribs) 03:45, 28 May 2021 (UTC)
 * How do you wish to proceed? Do you want to try just reimplementing it, using the Inputbox template instead of the mw-ui-input &lt;div>? Mathglot (talk) 03:49, 28 May 2021 (UTC)
 * I think that would kinda defeat the point, which is to not use inputbox as the way that looks is outdated. If the mw-ui-input &lt;div> doesn't display consistently, for some reason, then the status quo should be kept (though I am curious as to why that is). Elli (talk &#124; contribs) 03:51, 28 May 2021 (UTC)
 * I forget the details, but I know that certain (probably most) Html elements are turned off on purpose, and anything that interacts with a server, like &lt;input>, are definitely turned off. They've provided some hooks like with Inputbox, and there's one for searching as well. Here's one that uses EditOptions:
 * I forget the details, but I know that certain (probably most) Html elements are turned off on purpose, and anything that interacts with a server, like &lt;input>, are definitely turned off. They've provided some hooks like with Inputbox, and there's one for searching as well. Here's one that uses EditOptions:


 * However, if you don't need the input box to be able to have a cursor placed in it, then you can still do it, of course; just create an input box offline looking exactly how you want it, then screenshot the rendered page, and upload it to Wikipedia Commons, and use the image in the template, instead of Inputbox. That will work for sure.  Just please get buy-in from a reasonable number of users of this template; or else, be WP:BOLD and just do it, and see if anybody complains; although that may take a while as it took me a month just to realize it was broken. Mathglot (talk) 04:38, 28 May 2021 (UTC)
 * I see ya. As I don't particularly care about this - pinging who made the original TPER. Elli (talk &#124; contribs) 04:47, 28 May 2021 (UTC)


 * There might be another approach that could work: open a discussion at Template talk:Inputbox, saying that it generates an old-fashioned look, and asking for it to be fixed there. Then all uses of it will improve, not only in this template. Mathglot (talk) 04:48, 28 May 2021 (UTC)
 * Huh. I'm busy right now, but I'll take a look at this later. The class is defined as part of the MW UI, but it works for me in every skin. I think the issue is probably somewhere in loading the JS to style the classes. I'll see if I can update Inputbox instead (probably with hard-coded style tags instead of trying to just use the MW UI classes). Thanks for the ping! Tol &#124; Talk &#124; Contribs 05:29, 28 May 2021 (UTC)

if it matters, you can get the current behavior without the Inputbox template; just use the  class on any permitted Html tag, such as, say, the &lt;p> tag, along with this style: If you can show me what the "newer", or "more modern" output looks like, I'm sure we can imitate it. Mathglot (talk) 03:19, 29 May 2021 (UTC)
 * Hi ,Tol and Elli!
 * Hi ,Tol and Elli!
 * The class isn't even necessary, just the style. Here's a different one that resembles how it looks on my phone; is this what you meant by "modern"?:
 * Example: fixed typo, added content
 * Mathglot (talk) 17:44, 1 June 2021 (UTC)
 * Not quite. English Wikipedia Template "The edit-summary field" at revision 1020034884.png It was designed to look like the desktop version of the edit summary in the default WikiEditor (see the Wikimedia OOUI demos; it's similar). Tol  &#124; talk &#124; contribs 18:19, 1 June 2021 (UTC)


 * , thanks for the image. But now I'm more confused than ever, since that image looks very close to the way the template renders it now, at least when I look at it. The only differences I see between the two, is that the template uses inset style on the input text field (i.e., the white box has slightly thicker borders top and left, which gives the illusion that the input field is a bit recessed below the surface of the screen, and the shaded part is grayer (#EEEEEE) compared to your image, which is slightly on the blue side of gray (#EAECF0). Everything else, height, width, border style, font color, size and style, are all equivalent as I see it. If there is anything else you see that is different, could you please describe it?
 * I've made a change to the sandbox to add a new parameter, new and if you include it with any non-empty value (e..g, y), it produces this:


 * and if you don't, it produces the default version, namely:


 * Does that work for you? Mathglot (talk) 00:53, 6 June 2021 (UTC)
 * If that should be the default for all mobile users, we could use if mobile instead of requiring the new param, but allow it as an override. Another way to do it, would be to not change the template at all, but just add code to your commons.css for class, and then you can do anything you want. I'll maybe mock up a version of that for you, then we don't have to change the template.  Although, that would require opt-in, meaning mobile users wouldn't see it by default, which I gather was not what you were going for. But if you just want it for yourself when logged in, you have that capability already. Mathglot (talk) 01:05, 6 June 2021 (UTC)
 * This looks right. I can check the CSS later. The "new" version is the default (WikiEditor) appearance, so it should mimic that appearance as much as possible. Creating a "new inputbox" template might also be a good idea; I can work on that. Tol  &#124; talk &#124; contribs 19:06, 6 June 2021 (UTC)

Try again
@Mathglot, Elli: I've fixed the issue (see Template:The edit-summary field/OOUI). I've made three subpages: This way, they can all be edited and used separately. Because of this, I would like to change this page to use Template:The edit-summary field/OOUI. Do you think that transcluding it or copying it would be the best option? I personally support transcluding it: all past and future templates would have the OOUI version, but people could also transclude another version with the expectation that it won't change in the future. Tol (talk &#124; contribs) @ 02:28, 30 October 2021 (UTC)
 * Template:The edit-summary field/old, the pre-OOUI style that the template currently uses;
 * Template:The edit-summary field/OOUI, the style that is currently used by the MediaWiki default (textarea) and our default (WikiEditor, which is a toolbar on top of the textarea);
 * Template:The edit-summary field/VisualEditor, the style used by VisualEditor and the 2017 wikitext editor.

Edit request


Due to there being no opposition for a week to the above proposal (I've also included some wording changes), please implement the following change (which can be copied from the sandbox at revision #1054261722):

Thanks, Tol  (talk &#124; contribs) @ 01:15, 9 November 2021 (UTC)
 * ✅.  P.I. Ellsworth &numsp;- ed.  put'r there 04:34, 9 November 2021 (UTC)
 * @Paine Ellsworth: Thanks! I always appreciate you taking care of my edit requests. Tol  (talk &#124; contribs) @ 04:43, 9 November 2021 (UTC)
 * It's my pleasure!  Paine  04:48, 9 November 2021 (UTC)

Requested move 7 December 2022

 * The following is a closed discussion of a requested move. Please do not modify it. Subsequent comments should be made in a new section on the talk page. Editors desiring to contest the closing decision should consider a move review after discussing it on the closer's talk page. No further edits should be made to this discussion. 

The result of the move request was: moved. (closed by non-admin page mover) &mdash; Mdaniels5757 (talk &bull; contribs) 00:52, 15 December 2022 (UTC)

Template:The edit-summary field → Template:Edit summary field – Per the Manual of Style, Do not use articles (a, an, or the) as the first word. While the MoS does not explicitly apply to non-article-space pages, it establishes standard convention for page titles. Additionally, per Help:Edit summary, "edit summary" is not spelt with a hyphen. Cheers! 🐶 EpicPupper (he/him &#124; talk) 22:44, 7 December 2022 (UTC)

The discussion above is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.
 * Agree – Sounds right to me. Eric talk 05:07, 8 December 2022 (UTC)
 * Support. Cleans up the title sensibly. ModernDayTrilobite (talk • contribs) 21:32, 13 December 2022 (UTC)