Template talk:GA/Topic

Category
Please consider adding  to the bottom of the template. Thanks. -- Suntag  ☼  00:28, 22 November 2008 (UTC)
 * ✅ Skier Dude  ( talk ) 05:09, 23 November 2008 (UTC)

Classification
The new categories would be: The standard text would be "These articles are classified as "[Add category name]" Good Articles." I don't know of any other templates that use this one either. AIR corn (talk) 05:42, 5 March 2012 (UTC)
 * I have just moved the WP:GA pages around, effectively making Good articles/Everyday life and Good articles/Arts redundant (they are now covered by Good articles/Music, Good articles/Sports and recreation etc). This template needs to be updated to reflect these changes. I have left some code in the sandbox that I think will accomplish this. Could someone please deploy it. AIR corn (talk) 08:29, 1 March 2012 (UTC)
 * I have forked the history good articles to give the Warfare section its own page; Good articles/Warfare. The template needs to be updated to reflect this, please. — Ed! (talk) 17:31, 3 March 2012 (UTC)
 * I've bunched both requests together because it would probably be easier to handle them both at once. For whoever handles this (it might be me, I don't know if I'll have time) GA would also need to be edited so that it correctly uses a/an. In addition, this would change how article talk pages are categorised so some new category pages might need to be created. Tra (Talk) 03:16, 5 March 2012 (UTC)
 * Let me know what I can do in my non-admin powers to help out with anything. AIR corn (talk) 03:26, 5 March 2012 (UTC)
 * Thanks for the offer! If you could put Ed's changes into the sandbox version as well then that would be helpful. For the categories, we'd need to get a list of which ones would be created, and have the text ready to go in the category pages. Also I'm not sure if there are any templates apart from GA and ArticleHistory that use this and if so, it would be good to check if any of them require any additional changes. Tra (Talk) 03:53, 5 March 2012 (UTC)
 * Agriculture, food and drink good articles
 * Art and architecture good articles
 * Music good articles
 * Sports and recreation good articles
 * Theatre, film and drama good articles
 * Video games good articles
 * Warfare good articles
 * I just checked - Template:Peer review/Topic needs changing as well. I'll have a look at this. Tra (Talk) 13:35, 5 March 2012 (UTC)

That and GA now handled - these are links to create the categories: Category:Agriculture, food and drink good articles Category:Art and architecture good articles Category:Music good articles Category:Sports and recreation good articles Category:Theatre, film and drama good articles Category:Video games good articles Category:Warfare good articles Tra (Talk) 14:03, 5 March 2012 (UTC)
 * Ok, all ✅. If there are no further objections for four days then the old categories can be tagged with Db-c1. By the way, towards the bottom of the template you added a line break at }} after the braces. This broke the template so I had to take it out. Tra (Talk) 14:41, 5 March 2012 (UTC)
 * It looks good. I will tag the old cats and now redundant Good article pages if nothing more arises. Thanks for doing this. AIR corn (talk) 03:54, 6 March 2012 (UTC)

Problems, and a proposed solution
This page serves as a lookup table for matching a topic string to a valid GA main topic, but it's not handling everything it should be: When the lookup table finds no match, it returns no result to the requesting template. This has minor ramifications for some requesting templates, but is problematic for ArticleHistory (which throws an error on a blank topic) and for GA and Peer review/Topic (which use the topic to categorize the tagged page).
 * 1) some actual topic names are not being parsed at all (such as 'Warfare');
 * 2) some subtopics are not being matched to the correct main topic ('ballet' and 'dance', for example, used to belong in 'Music' but now belong in 'Theatre, film and dance'); and
 * 3) many common synonyms and abbreviations for topic/subtopic names are not being matched ('technology' and 'songs' are examples that don't parse).

I have drafted a revised lookup table in the sandbox to hopefully address these issues. I reorganized the lookups so that each line begins with the valid GA main topic name, listed in the order given at WP:GA for easier upkeep. I cross-checked with the listings at WP:GA to ensure I'm matching subtopics to the proper main topic. I was careful to retain all the lookup values from the current version (to avoid affecting existing transclusions), and added common synonyms and abbreviations to widen the net.

I would appreciate review and comment, particularly if anyone spots some potential collateral damage that I haven't taken into account. Maralia (talk) 04:38, 16 February 2013 (UTC)
 * I've gone ahead and added this to the template. — Mr. Stradivarius  ♪ talk ♪ 14:18, 28 February 2013 (UTC)

Edit request on 22 February 2013
Theatre, film and drama parameter needs to be changed to per the name change to "Media and drama" per the name change on the nominations page. If this can not be done, a new parameter should be created.

Dom497 ( talk ) 21:49, 22 February 2013 (UTC)
 * Pictogram voting question.svg Question: I foresee a potential problem with this. At the moment if someone uses the "media" alias then the template returns "Social sciences and society" (as in journalism, etc.), but if the theatre, film and drama parameter was changed to "Media and drama" then people may use the "media" alias to mean Media and drama and they might be surprised to see that they have entered "Social sciences and society". What do you think the best way of dealing with this situation would be? — Mr. Stradivarius  ♪ talk ♪ 14:23, 28 February 2013 (UTC)
 * I've temporarily disabled this request; will reenable it once I've got appropriate code ready to go in the sandbox. Maralia (talk) 14:07, 1 March 2013 (UTC)
 * Thanks for pointing this out, but the change from 'Theatre, film, and drama' to 'Media and drama' has not been fully incorporated at WP:GA (WP:GAN uses it, but WP:GA does not, nor does the associated category), so I am reluctant to include it here until GA has ironed out the differences. Have asked User:Aircorn for comment. Maralia (talk) 14:55, 1 March 2013 (UTC)
 * I have tried to get the WP:GA and WP:GAN pages to match up and I think for the most part they do now. There might be some rearranging to do within the Good articles/Media and drama page but that shouldn't have an impact on this. AIR corn (talk) 08:46, 7 March 2013 (UTC)
 * Pictogram voting question.svg Question: I'm going to need more details about this in order to fulfil the request: if we change the heading from 'Theatre, film, and drama' to 'Media and drama' here, what would you like to do with the "media" alias in the template? Should it still output "Social sciences and society"? And if not, what should we do with all the pages that already use GA with the "media" alias? We might need to go through and change all of the transclusions before we can change this template. (Not that that's necessarily a bad idea, but it will require some thought about how to implement it.) — Mr. Stradivarius  ♪ talk ♪ 10:26, 7 March 2013 (UTC)
 * I think Maralia has already changed the media ones so they point in the right direction. I am planning to go through and mop up all the ones, not just media, that link to the wrong GA subpage sometime in the future. There were already quite a few pointing to the old Theatre, film and drama page even though they were listed under Media and Journalism when I moved them so I don't think it would be a major problem if some temporarily linked to the wrong page. As to media, it should now be made to output "media and drama". AIR corn (talk) 11:06, 7 March 2013 (UTC)
 * Thanks for responding again, Mr. Strad. You are of course right about existing pages with topic=media; I have been altering those so that they fall properly into the new scheme. In addition to the 'media' change, though, WP:GA has also changed many subtopic names (some of which are also aliases in this lookup table). I expect more adjustments will be necessary, and I'd like to get them all done at once, but I am running out the door to an appointment. I've temporarily disabled the edit request; will be back in a couple of hours. Maralia (talk) 15:31, 7 March 2013 (UTC)

I've updated the sandbox code but I'm not quite ready to implement. I want to finish going through Category:Uncategorized good articles to look for 'bad' topic names (might as well fix common errors while I'm at it). I'm off to bed but will get back to this in the morning. Maralia (talk) 04:13, 8 March 2013 (UTC)

Template broken
Could someone with the proper access revert this edit? It's causing Template:GA to display with a hard return in the middle that's breaking the links. -- Khazar2 (talk) 16:04, 28 February 2013 (UTC)
 * ✅ -- Khazar2 (talk) 16:05, 28 February 2013 (UTC)
 * Very sorry about that - I should have noticed something was wrong from the test cases. I've reinstated the changes without the syntax error, so hopefully everything should be working now. — Mr. Stradivarius  ♪ talk ♪ 21:29, 28 February 2013 (UTC)
 * My bad—the changes in the sandbox you incorporated were mine, and I didn't create that test cases page until I saw the error report here, so you couldn't have known. Thanks very much for your help! Maralia (talk) 23:06, 28 February 2013 (UTC)
 * I've had to update the sandbox code to accommodate serial commas in the lookups; could I trouble you to implement, please? Maralia (talk) 01:22, 1 March 2013 (UTC)
 * Nevermind for now; a little more work to be done first, to handle the request in the previous section. Maralia (talk) 14:07, 1 March 2013 (UTC)

Edit request on 12 April 2013
Please incorporate the changes from the sandbox. This will accommodate the new GA topic scheme which has been in effect for some time now. I have also tacked on some cleanup; details follow. There is some previous discussion of this in a thread at above. Maralia (talk) 02:43, 13 April 2013 (UTC)
 * 1) Changed topic 'theatre, film and drama' to 'media and drama'—per WP:GA. The media alias was already in use with a different meaning from the new intended one, so I first went through all pages tagged with topic=media and changed all instances to the relevant topic name under the new scheme.
 * 2) Removed 'arts' alias—I discovered that arts was being used as an alias for everything: it was mapped to the 'Art and architecture' topic, but was in wide use on film, music, book, and other articles too. I went through all of the 2,000+ pages that were tagged with topic=arts and changed each to the proper, relevant topic. Moving forward, any pages newly tagged with the deprecated topic=arts will be handled the same way that 'wrong' topic names are handled now: pages tagged with GA will end up in Category:Uncategorized good articles; while pages tagged with ArticleHistory will end up in Category:ArticleHistory error.
 * 3) Removed unused and unlikely-to-be-used aliases.
 * ✅ Ruslik_ Zero 18:58, 17 April 2013 (UTC)
 * Thanks! Appreciate if someone would also incorporate the single follow-up edit I made to the sandbox (I had inadvertently removed a couple of old aliases that were still in use). Many thanks. Maralia (talk) 00:01, 18 April 2013 (UTC)
 * ✅ Ruslik_ Zero 19:42, 19 April 2013 (UTC)
 * These changes have broken the peer-review process, see WP:VPT. →  →  →  →  -- Red rose64 (talk) 17:08, 18 May 2013 (UTC)