User:MarkAHershberger/Weekly reports/2010-W02

The second week of work went pretty smashingly. (For those who may wonder: These weekly reports are a contract requirement.)

tests
I started incorporating the parser tests into the phpUnit test runs. I've tried to depend on parserTests.inc wherever possible, but I'm not sure at this point how much of the Mediawiki CLI infrastructure (commandLine.inc, Setup.inc, etc) should be included in the unit tests.

I've also started thinking about how to perform multiple runs of the tests -- how can we have regression testing running automatically under different configurations?

LanguageConverter.php
Feedback from Tim Starling and others came trickling back in this week and I was able to address a few mistakes. For instance, prior to r61101, I didn't understand all the places and ways that Title objects are used and abused mTitle instead of using mOutput->setTitleText.

HttpFunctions.php
After seeing a discussion in #wmfstaff in which some staff were unfavorably compared to the volunteers, I asked Tim what I could to do help. After his initial comments on the delayed download work and pure-PHP implementation of an HttpRequest, I started to tackle that. Since I'm still flying blind when it comes to the overall architecture of Mediawiki, I left in the delayed download work. Tim later asked me to remove it. I plan on using this opportunity to learn about the JobQueue.

Other
I'm still enjoying the "trial by fire" method of work and still learning the coding conventions and expectations. The code review extension is a great way for getting feedback -- at least so far.

= Raw Notes =

11

 * got tests/* working on all DBs
 * Fixed non-working tests except those that need DBadmin for now
 * Fixed bug in getPreferredVariant where it caches the variant during ParserTests

12

 * Final(?) cleanup of getPreferredVariant.
 * memoized all get*Variant functions
 * created validateVariant function
 * fixed up tests for variants -- they actually make sense now.
 * Started enabling parserTests to run under tests/* so all tests will run with one phpUnit invocation.

13

 * Fixed problems found by philip
 * mostly this seemed to be logic errors I overlooked.
 * Did a little more work on getting parserTests to run under tests/*
 * Seems like I have to get some setup for parsing Image links that isn't done yet.
 * Started cleaning up HttpFunctions.php after conversation in #wmfstaff indicated a need for it.

14

 * Finished first pass over HttpFunctions.php
 * Abstracted out the request structure so CURL & PHP could share more code
 * Found all uses of HttpFunctions in SVN -- overwhelmingly, get is the one to get right ;)
 * Fixed some minor issues from CodeReview

15

 * Got notice from translateWiki that HttpFunctions rewrite had messed up some php warnings.
 * Suspect this is from the un-tested parser code
 * Might just need to @-supress some PHP fopen errors.
 * Read and attempted to address Tim's review of previous work