User:MarkAHershberger/Weekly reports/2011-07-11/log/2011-07-07


 * Tried applying patch to get HTTPRequest to respect no_proxy and made the mistake of not thorougly reviewing it.
 * While I understand the developer's frusatration at seeing patches applied w/o being reviewed, I think the quick application of this patch shows a couple of things:
 * The patch submitter was still around and interested when the patch was reviewed
 * Developers only sporadically look at patches in Bugzilla, so submitters are less likely to get speedy feedback.
 * Bz probably could benefit from more hands-on review. I have a whine set up that sends me a list of newly submitted patches.  It might be good to get this email broader distribution.
 * Helped a WMDE dev with email
 * Daniel_WMDE was trying to get to go out with the proper envelope sender on outgoing mail. After I tracked down $wgAdditionalMailParams and pointed him to it I noticed there wasn't an equivlent setting for the PEAR mailer used when $wgSMTP is set.  I patched it up, but there still might be room for improvement.
 * Helped NikeRabbit with TWN emails and fixed Email notifications being sent out to users without email addresses
 * He contacted me a couple of days ago about emails going from TWN without an actual email address.
 * After looking at the problem, I saw that UserMailer didn't actually check to make sure that it had an email before sending mail. Fixed.
 * Discovered the Joy of Unicode is like the Joy of XML
 * While looking through new bugs, I saw this regression that NikeRabbit had found. Tracking down the source of the problem took some time.  But I did find the bit to fix.  SPQRobin fixed the unobvious problem with my fix.