User:MarkAHershberger/Weekly reports/2011-08-01


 * Updated Revison Report
 * Not enough code review being done. It looks like I'll have to be noisy on wikitech-l this week and start pushing assignments for review


 * Attempted to make revision tags accessible via the api
 * While trying to figure out how to (possibly) move the generation of the revision report off of toolserver, I found that the API for CodeReview supported getting lots of different information from a revision, but not the tags that were applied in CR.
 * fixed


 * Continued trimming the fat off of assigned bugs
 * After contacting developers who had default assignments set up in Bz, I found a few who wanted out. Most notably, the maintainer of Proofread Page — which wikisource depends on — said he didn't have any time to maintain the extension.


 * Email sending work
 * A couple weeks ago Niklas showed me an example of email notifications being sent out to users without email addresses and who aren't confirmed — a bounced email that TranslateWiki.net had gotten for an email that was sent out. (I once helped the twn people set up mailman and route their mail through a clean server for them.)
 * For some reason, MediaWiki was sending email to users without an email address. After looking at the code in UserMailer.php, I saw that there was no check to make sure that the user actually had an email address before sending out the mail.  So I added one.
 * Another problem was one I discovered then: MW has two different ways to send email (PHP's mail or Pear::Mail) and sets up the email headers slightly differently. So I refactored that bit.
 * I was thinking how I could write some tests for all this, but realized that it wasn't very testable. Bug #28026 — at least the logging part — could be solved by making UserMailer more testable as well.  After thinking about that, I realized that a hook would do the job wonderfully for both testing and logging.
 * Unfortunately during all of this thinking about testing, I didn't actually do much testing of my code. So there are several FIXMEs that I had to deal with.  Not too surprisingly, I suppose, Brion posted a message to wikitech-l — Please don't commit broken code — and I was reminded, once again, how important it is to use a checklist.
 * It was more embarassing then it needed to be.


 * IWTransclusion merge
 * Spent some time this past weekend finding and fixing a couple of problems that Reedy had asked for help on with the IWTransclusion merge.