User:Sabinaazim/Hash collision/Saharae Peer Review

General info

 * Whose work are you reviewing?

Sabinaazim


 * Link to draft you're reviewing
 * Hash collision
 * Link to the current version of the article (if it exists)
 * Hash collision

Evaluate the drafted changes
(I don't think there's a draft yet, so I'm just gonna comment on the original and hope that helps when drafting!)

Lead:

The lead does a good job introducing the topic and giving a broad overview of the background and dangers of hash collisions. I'd say it could probably benefit from being a little more detailed, but in simpler terminology. I appreciated that everything was hyper linked, but maybe if the initial sentence didn't have to link 4 different technical articles it would be more accessible.

Content:

The actual body of the article I think is where it can benefit the most from editing. Its very short with only one section about computer security, and doesn't even go into too much depth about computer security, only that collisions have the ability to disclose passwords. I think there's a lot of detail that can be brought into this section and it might even be able to be split into multiple sections about the different ways that hash collisions can threaten security.

A "history" section might also be useful here. Encryption has been around for so long and evolved so dramatically, it might help to set the scene for why collisions are such an important topic. More examples could also help with this point, it could even bring in what we researched with the CSAM detector and Apple to give real world context. There's already one example in the article to help illustrate the process of a collision, but an example that people would relate to in their lives could be very powerful.

An illustration about the process of a collision might also be beneficial, to make it easier to understand for people who aren't well versed in hash algorithms.