User talk:Kithira/Course Pages/CSCI 12/Assignment 2/Group 3/Homework 2

A well done, concise and useful program. My only comments are about the explanation of the program. In the first paragraph, instead of referring to the input as "our integer", I think it would be clearer if you just referred to it as "the input" or "the inputted value". In the second sentence especially, I think that "It divides the inputted value by each integer" would be a tad clearer and more precise than the current wording, "It divides our original integer by each number". For the explanation of the remainder being zero, I think something like "the inputted value is a multiple of that number" or "the inputted value is evenly divisible by that number" would be clearer. At least personally, I think the current wording would include things such as 5 divided by 2 (which, although it does not divide evenly, does divide "nicely"). The step by step explanation of the function is excellent. Each line of code is explained with great clarity. My only comment would be that line 6 is a bit hard to understand the first time I read through it. I think that line would be a little clearer if it ended after "our variable list " and did not include "by being added to our the list stored within that variable."

Neubauermike (talk) 20:25, 13 January 2013 (UTC)

I agree with the above user. I also like that there were many differing assert statements. The program creator made sure that every possible option was tested and correct. Alexandra D16 (talk 06:04, 14 January 2013 (UTC)

I also aggree with Neubauermike that the description could be a little clearer. For the most part though, I think it is a very clear and well tested piece of code. -- Rather than checking every integer, "count", between 0 and x, alternatively, you could check every integer, n, between 0 and root(x). If you added n AND x/n to the list, the program would not have to loop as many times, but you would get the same results. LucieColeman (talk) 13:47, 14 January 2013 (UTC)