User talk:Terasail/Edit Request Tool

Please ping me when adding a new message to this page to allow for me to respond quicker.

Features and bugs

 * @Terasail So adding custom text on top of the template defaults should pose no problem? Also, does it (will it?) work with Template:Request edit - asking because EPH doesn't do that. RandomCanadian (talk / contribs) 17:04, 25 January 2021 (UTC)
 * @RandomCanadian It doesn't work with COI, since the box does not have an "editrequest" class which makes it more difficult to detect. I would assume its a similar reason to why EPH doesn't do it either. And it should work with custom text, although I am not sure exactly what that means. Terasail &#91;✉&#93; 17:11, 25 January 2021 (UTC)
 * Compare this with the default output of 🇪🇸 and you'll get what I mean. Anyway, thanks for answering my questions. I'll give it a try and see if it works better for me than EPH. RandomCanadian (talk / contribs) 17:22, 25 January 2021 (UTC)
 * The remove (red bin) button doesn't seem to work; ended up doing it manually here, tell me if it works for you. Also, I'll move this part of the discussion to the relevant talk page. RandomCanadian (talk / contribs) 17:29, 25 January 2021 (UTC)
 * Thats an error I will go and figure out now, however it is rare as it will work 95% of the time. For example here. Not sure why that happened but I will figure it out, thanks.
 * I just fixed that error, it was caused because there was text before the edit request box. It will not break from that reason again. Sorry about that one. Terasail &#91;✉&#93; 18:13, 25 January 2021 (UTC)
 * A bit of a slightly embarrassing one, although its nothing major (relibale...) RandomCanadian (talk / contribs) 05:04, 28 January 2021 (UTC)
 * Thanks, I fixed that although I now realise that I have about 80 edits with a spelling mistake... Terasail &#91;✉&#93; 10:06, 28 January 2021 (UTC)

"Comments" and answered option
This (the "Comment" option) probably shouldn't have marked the template as answered. Cheers, RandomCanadian (talk / contribs) 23:42, 20 February 2021 (UTC)
 * To stop the template from being marked as answered, click the "Close" button, which should toggle to a while colour and be marked with an X. This should leave the template as unanswered. It is not easy to mark all comments as not answered, since if a request is closed and a comment is added after the fact, the request would not want to be reopened. Unless you were saying that the toggle button didn;t work in which case I can look into it? Terasail &#91;✉&#93; 23:46, 20 February 2021 (UTC)
 * Ah ok, wrong button, my bad. Another issue I've encountered is when clicking cancel and trying to re-submit afterwards. Any thoughts into that? 23:49, 20 February 2021 (UTC)RandomCanadian (talk / contribs)
 * Turns out there was an error with the close toggle button when there are multiple templates on the same page, and both of them were caused by me forgetting to use local instead of global variables. Both problems (including cancel followed by a resubmit) should be fixed now. Terasail &#91;✉&#93; 00:03, 21 February 2021 (UTC)

Suggested edit
I have made some changes (mostly UI changes) at User:GKFX/Edit_Request_Tool.js (diff), as it's currently not immediately obvious what each button will do just by looking at the tool. Summary: Let me know what you think. User:GKFXtalk 21:03, 16 April 2021 (UTC)
 * Add title text to buttons so there is more than just an icon saying what will be done.
 * Change the "Close" toggle-button to a checkbox, as this is more conventional and therefore more understandable UI.
 * Make the buttons wrap on small screens/resized windows.
 * Add  keyword where it has been forgotten.


 * Thanks for the suggestions, I have changed the close button to a checkbox, just not in exactly the same way you did, and they will now wrap properly aswell. I have added title text to all of the buttons aswell and applied all the missing var's you pointed out as well as some other changes mixed in aswell. Terasail &#91;✉&#93; 14:18, 17 April 2021 (UTC)

Error report: :Go Ahead” not working
When using the tool, I get “Failed to find template, please report to “User talk:Terasail/COI Request Tool”

Ben ❯❯❯  Talk  16:13, 24 May 2021 (UTC)

WP:Reliable button invokes WP:Consensus closure
Hello. In this diff I selected 'WP:Reliable' button, but it closed the request as if I clicked 'WP:Consensus button'. I'm sure I did not miss-click the wrong button since in previous edits you can see, I got an unexpected behaviour and was like "Did I click the wrong button?" so I reverted myself and tried again, and the behaviour persisted. Mel ma nn  18:22, 29 July 2021 (UTC)


 * I just did a significant update so it was probably caused by that. Let me look into it. Terasail II &#91;✉️&#93; 19:18, 29 July 2021 (UTC)
 * When I added the option to change the level of the edit request I forgot to update the shotcut button values. This should be fixed now, thanks. Terasail [✉️] 19:26, 29 July 2021 (UTC)

WP:Reliable button (or selecting it manually without adding further input) does not get processed, does not save changes
What is says on the tin. I tried at Talk:Turkey or Talk:David Geffen, but it hasn't worked at either, so I had to resort to doing it manually. RandomCanadian (talk / contribs) 00:38, 10 August 2021 (UTC)


 * I have just tested the WP:Reliable button at Talk:David Geffen with this edit: Special:Diff/1038250187 and it worked correctly. I can't at the moment figure out why it would not work for you, it may have been that the edit edit request was just being slow at the time? If this happens again please reply and I will search for a fix. Thanks, Terasail [✉️] 12:08, 11 August 2021 (UTC)

Some requests
Hi I have some requests regarding this tool, you may want to implement: In the drop-down list, it feels as if this template puts the green colored message on just any page. At least, that's what I thought until I saw the actual template code. And so I felt it to be useless until I realised that it's not. Thanks! ---CX Zoom(he/him) (let's talk&#124;contribs) 05:16, 1 March 2022 (UTC)
 * 1) I recently changed the sequence of responses in the EP's documentation, to bring higher usage ones on top and categorise them into groups based on similarity, which you may want to bring to the tool too.
 * 2) I did a minor change to the message shown for "Partially undone", which is currently not reflected in the tool.
 * 3)  and  messages in the tool are kinda misleading. For example, for the former, the drop-down list in the tool says Not done: this is the talk page for discussing improvements to the template ... In the template documentation, this message appears, but elsewhere it does not, as this response automatically takes into account namespace and page name. For example, using it here, yields a completely different response: Red information icon with gradient background.svg Not done: this is the talk page for discussing improvements to the page User:Terasail/Edit Request Tool. If possible, please make your request at the talk page for the article concerned. If you cannot edit the article's talk page, you can instead make your request at Requests for page protection.


 * @CX Zoom Thanks for letting me know, I will update the order and fix pud, mis & tp messages. I am unclear on what you mean by "the green colored message" in the drop down list. Terasail [✉️] 14:30, 1 March 2022 (UTC)
 * Oh I meant, the option that appears in the list, which *I* colored in green above for emphasis. Thanks again for making the changes. ---CX Zoom(he/him) (let's talk&#124;contribs) 15:05, 1 March 2022 (UTC)
 * @CX Zoom Oh that makes sense, I thought there was an error highlighting options green or something. Will get on it will probably be done in the next few days. Thanks, Terasail [✉️] 16:45, 1 March 2022 (UTC)
 * ✅ Terasail [✉️] 11:06, 10 March 2022 (UTC)

Buttons not producing the right output
I'm having an issue where the buttons aren't producing the right output. For example, clicking Unclear: X-Y produces the WP:Reliable output, and clicking WP:Consensus produces a simple "Not done for now". Any idea what the cause might be? It worked properly until the past two days. Thanks, CMD (talk) 08:42, 2 March 2022 (UTC)


 * @Chipmunkdavis Hello, sorry for the slow response but this issue should now be fixed. Thanks, Terasail [✉️] 11:07, 10 March 2022 (UTC)

oops I accidentally an edit request
@Terasail - any clue what happened here? casualdejekyll  14:24, 14 March 2022 (UTC)


 * Not too sure at first glace, will look into it. Thanks, Terasail [✉️] 14:28, 14 March 2022 (UTC)
 * and it happened again. I've never had this issue before, what happened? @Terasail casualdejekyll  15:18, 14 March 2022 (UTC)
 * @Casualdejekyll This should be fixed. I tested it here and it worked as expected. Thanks, Terasail [✉️] 15:22, 14 March 2022 (UTC)
 * Quick fix! Wonder what the issue was, anyway.. casualdejekyll  15:24, 14 March 2022 (UTC)
 * It was caused because of an error in the way I stored pagelength, so when it was the last section on a talk page, it couldn't find the end of the page and just replaced the section with a duplicate of the section before. Terasail [✉️] 15:26, 14 March 2022 (UTC)

Preview doesn't like tq template
The preview for this response rendered an error for tq, saying it can only be used in talk space, not in articles. When I submitted the reply, everything worked out fine. ScottishFinnishRadish (talk) 23:04, 7 July 2022 (UTC)


 * @ScottishFinnishRadish, thanks I will look into this I am busy today but will have a look at the saturday/sunday. Terasail [✉️] 09:57, 8 July 2022 (UTC)
 * Nevermind I just realised what the problem is, its very simple so I will upload a fix soon. Terasail [✉️] 10:17, 8 July 2022 (UTC)
 * Thanks! ScottishFinnishRadish (talk) 10:19, 8 July 2022 (UTC)
 * @ScottishFinnishRadish This should be fixed now. Terasail [✉️] 10:22, 8 July 2022 (UTC)
 * Thanks for the quick fix. ScottishFinnishRadish (talk) 16:49, 8 July 2022 (UTC)

Remove edit request
It would be nice to have a second option for removal, specifically for empty edit requests that automates posting empty edit request to the talk page of the requesting editor. This might be tough, since you'd have to find who created the request, or pick out the signature. Also, it would be nice if there was a pop-up or text field or some such when removing a request so a custom edit summary could be added. ScottishFinnishRadish (talk) 23:13, 7 July 2022 (UTC)


 * I will look into adding this, thanks Terasail [✉️] 09:57, 8 July 2022 (UTC)
 * I too think both of these additions would be useful, especially the ability to customize or provide one's own custom edit summary. --Pinchme123 (talk) 16:07, 8 August 2023 (UTC)
 * @Terasail didn't realize you request pings when new comments are left here. I know it's been a couple days, but I thought I'd add the ping anyway just in case. --Pinchme123 (talk) 00:34, 11 August 2023 (UTC)
 * @Pinchme123 thanks for this information, I originally added the feature but had to remove it again after some mediawiki updates stopped the feature from working properly. The reason I request pings is so that I can see messages when I don't have access to my main account (For the last week) which is why O didn't see your message. I will look into adding it again but it might take a few weeks. I will have access to my account from next week onwards so I can look into it then. Terasail II  [✉️] 10:36, 11 August 2023 (UTC)
 * @Terasail no worries at all. I didn't mean to come across as impatient; I saw your note requesting pings and realized I should probably honor your request, even if belatedly.
 * This tool is so great, by the way! Even if you are never able to add this feature back in, it's so incredibly useful as-is that I couldn't imagine going back to manually responding the way I was before. So no rush at all.
 * --Pinchme123 (talk) 15:27, 11 August 2023 (UTC)
 * I wanted to circle back to this, to see if you've made a decision about whether or not to reimplement this functionality? All the best. --Pinchme123 (talk) 21:38, 24 November 2023 (UTC)
 * @Pinchme123 I am not actively looking to re-implement this ability at the moment (It is a tricker problem than it may first appear). At some point I will update the code for the tool and at that point I may look into doing this again, but I don't have a timeline on that at the moment. Terasail [✉️] 13:49, 25 November 2023 (UTC)
 * No problem, just thought I'd check in about it. --Pinchme123 (talk) 01:56, 26 November 2023 (UTC)

Bug handling external links with ampersands
, when adding external links that contain & it cuts off everything after the last character of the URL and shows the opening [ in the preview window. ScottishFinnishRadish (talk) 17:26, 19 July 2022 (UTC)


 * @ScottishFinnishRadish This should be fixed now the preview should work with links containing special characters. Turns out api's don't like &'s. Terasail [✉️] 17:58, 19 July 2022 (UTC)
 * Looks fixed from here, thanks for the quick turn around. I'll let you know if I see any other issues. ScottishFinnishRadish (talk) 18:06, 19 July 2022 (UTC)

Indent bug
, got another one for you. When responding to an edit request the to indents in response to the last message, rather than the request itself, making it appear that you're responding to the wrong editor. For example. ScottishFinnishRadish (talk) 22:59, 20 July 2022 (UTC)


 * @ScottishFinnishRadish Yeah, it is just the way it is designed, there is no easy way to select the indent. And with options such as undone and question it is normally better to indent to the last message. There is no perfect solution and I think that people can understand even if the indent isn't quite correct. Terasail [✉️] 11:52, 21 July 2022 (UTC)
 * Is there a way to always just set the indent level to one? I feel that if there was a specific question for a specific user the reply tool or Bawl or somesuch would be used, rather than the edit request tool. ScottishFinnishRadish (talk) 11:54, 21 July 2022 (UTC)
 * True I did make that system before the reply tool was around. I can change it, and with the reply tool now being default it probably makes more sense now. Terasail [✉️] 13:01, 21 July 2022 (UTC)

Edit conflict/blanking bug
I assume that happened because of an edit conflict? ScottishFinnishRadish (talk) 17:24, 25 September 2022 (UTC)


 * , whoops, forgot the ping. ScottishFinnishRadish (talk) 17:24, 25 September 2022 (UTC)
 * @ScottishFinnishRadish On a quick look it appears to have been caused by the edit conflict, and since the section was no longer there, and it managed to slip past the recent edit detector it couldn't find the section and removed the whole page but I will look further into it tomorrow and see if I can add safeguards and confirm what actually happened. Terasail [✉️] 17:44, 25 September 2022 (UTC)
 * @ScottishFinnishRadish Unfortunately there isn't much I can do here. I have spent some time double checking that the edit conflict checks I already have in place work as intended and they all appear to work well. It seems that you were just unlucky here and once the edit had already been submitted to the servers, the page was updated meaning there is nothing that I can do to prevent this. (If you had submitted 1-2 seconds later my checks probably would have alerted you with a warning message). Terasail [✉️] 21:22, 6 October 2022 (UTC)
 * Also congratulations on passing your RfA! Terasail [✉️] 21:24, 6 October 2022 (UTC)
 * Thanks for taking a look, and thanks for the congrats. Much appreciated. Have you had a chance to look into automating adding the empty edit request notice to the requester's talk page when removing edit requests yet? ScottishFinnishRadish (talk) 21:34, 6 October 2022 (UTC)
 * I am slightly busy at the moment, my uni year just started up again but it is on the to-do list. Terasail [✉️] 21:37, 6 October 2022 (UTC)
 * No rush, and to be honest I think in 99 percent of cases it wouldn't make a difference, as most of those are test edits or attempted vandalism. ScottishFinnishRadish (talk) 21:40, 6 October 2022 (UTC)

Add Request Withdrawn option
It'd be nice if there was an option to respond with Request Withdrawn when the edit request says "ignore" or something like that. Aaron Liu (talk) 11:42, 14 October 2022 (UTC)


 * @Aaron Liu You can close the request by clicking the flag icon button, this will set the template to yes if however you wish to have a text response of "Ignore, this request has been withdrawn" you can either use the "comment" reply option and write this, or you can request that a new reply option be added to EP at Talk:EP. Terasail [✉️] 11:47, 14 October 2022 (UTC)
 * Clarification: What I meant was include an option to respond with Withdrawn. Aaron Liu (talk) 11:51, 14 October 2022 (UTC)
 * @Aaron Liu The easiest way to do that would be to use the "comment" reply option and in the text box place Withdrawn. I think that the systems in place (Last sentence) are adequate for this, so I am not going to add it as a feature at this time. However thanks for the suggestion. Terasail [✉️] 12:28, 14 October 2022 (UTC)

Subst’d templates don’t show up in preview
When I add to the additional text box in the tool, the expanded template doesn’t show up. Aaron Liu (talk) 19:42, 18 October 2022 (UTC)


 * @Aaron Liu This should be fixed now. Terasail [✉️] 10:32, 19 October 2022 (UTC)

Automatically subscribe to edit request responded to
If it's possible, add a feature to the tool so that when the "Automatically subscribe to topics" option is toggled in user preferences, the user automatically subscribes to the edit request topic after responding to it. Aaron Liu (talk) 15:02, 30 October 2022 (UTC)


 * @Aaron Liu It is an interesting idea. I would probably make it a checkbox, in the same way that the watchlist is currently a checkbox. However since it is a new feature I am not too sure about the apis available and I am not sure how practial it would be to implement this at this time. I will look into it, just don't hold your breath since it might just need time to be better intergrated into the MediaWiki software before I can add it. Thanks for the suggestion, Terasail [✉️] 22:21, 30 October 2022 (UTC)
 * You could perhaps look at Convenient Discussions to see how they subscribe. Aaron Liu (talk) 17:26, 29 October 2023 (UTC)

Somehow an edit request deletion blanked the entire talk page
https://en.wikipedia.org/w/index.php?title=Talk%3AFIFA_World_Cup&diff=1128213703&oldid=1128213571 receives the award for world cup chaos Aaron Liu (talk) 02:16, 19 December 2022 (UTC)


 * @Aaron Liu Do you know if this happened before? It looks like the edit was just requested twice for some reason and since it was removed the first time, the section couldn't be detected and deleted the page... Might just be one of those unlucky things. I will look into it but from my testing it should work fine normally. Terasail [✉️] 16:05, 19 December 2022 (UTC)
 * This is just speculation from me, but if that user had the edit request open on two different tabs, and requested the section removal twice in a row. This sort of thing could happen but without actually knowing more there isn't much I can do. Terasail [✉️] 16:08, 19 December 2022 (UTC)
 * Yeah that seems to be the most suitable explanation. The only thing I think can be done to “fix” this would be to error when it doesn’t detect. Aaron Liu (talk) 16:37, 19 December 2022 (UTC)
 * @Aaron Liu Yeah I was thinking of going through the code, updating parts of it and also updating the COI tool to match the edit reuqest tool. While I am doing that I will also add aditional checks but it won't be a "quick fix" it might take some time to come out since it doesn't seem to be a big issue. Thanks for bringing this up, Terasail [✉️] 16:55, 19 December 2022 (UTC)

Warn about empty edit request option gone?
I no longer see the option to send an empty edit request notice when removing a request. Did this get removed, or is there a bug afoot? This has been the case for a while now, but I just now remembered to bring it up, sorry about that. ScottishFinnishRadish (talk) 16:41, 9 January 2023 (UTC)


 * @ScottishFinnishRadish Yeah, I had to remove the option since I was making use of a feature to detect who posted the edit request but that feature was removed/changed. I haven't got round to fixing it since I have been doing a project off wiki so I have had no interest in looking into more code but that just finished this week so I will probably have a go at fixing it next week? Sorry about that. Terasail [✉️] 18:43, 9 January 2023 (UTC)
 * No worries and no rush. I didn't really use it as often as I was expecting to, since I didn't bother with drive-by IPs. ScottishFinnishRadish (talk) 19:05, 9 January 2023 (UTC)

Reopening request changes page requested
I just ran into what I think might be a slight issue - I just used the reopen request button and it altered the page for which the change is requested (which I did not expect) in addition to reopening the request. The diff is here.

Also, side note, "Reopened" is spelled incorrectly in the summary it generated.

Thank you so much for the tool! Tollens (talk) 00:57, 12 May 2023 (UTC)


 * Missed the message asking for the ping - there it is now. Tollens (talk) 03:44, 12 May 2023 (UTC)
 * @Tollens Thank you for reporting this, I corrected the spelling and fixed the script. Terasail [✉️] 15:30, 12 May 2023 (UTC)

Scrolling bug
Not sure the reason behind this, but when clicking the list of responses I have for a few days been unable to scroll up the menu to reach the top items like "Done" using the mouse. I solve this by clicking partly done and manually scrolling using the arrow keys. I haven't changed any of my personal setting recently, but using the previous Vector. Chrome 118.0.5993.70, Windows 11. (Haven't done much testing on different setups yet myself, so this is more a heads up than a request to put time into this.) Best, CMD (talk) 01:33, 16 October 2023 (UTC)


 * @Chipmunkdavis, I am unable to replicate this as you are describing after a quick check. Unfortunately the dropdown is made with OOUI which is out of my control and I can only control what is put inside. I will keep this in mind and think if there is anyway to mitigate this but I am not sure at the moment if there will be anything I can do here. Terasail [✉️] 12:55, 16 October 2023 (UTC)

More specific wording for removing edit requests?
Hi Terasail, right now when using the tool to remove empty edit requests, the edit summary simply says "Removed edit request" without elaboration, which might be a bit confusing to those not familiar with edit requests. Do you think it would be helpful to expand the wording of the automatic edit summary a bit more (something like "Removed empty edit request" or "Removed unconstructive edit request")? Of course, I could go into the page history and undo/Twinkle rollback the request and write my own edit summary, but that's a bit annoying to do every time. Liu1126 (talk) 17:17, 17 January 2024 (UTC)


 * @Liu1126 The reason why it is done like that is so that it can be used to remove any sort of edit request, be it empty, vandalism or otherwise. By adding context it means that there would need to be a way to select which type of removal it would be. I might try to think of a way to allow you to add your own comment to the removal summary but nothing will happen before the weekend. Terasail [✉️] 17:41, 17 January 2024 (UTC)

Underscore
In Special:Diff/1208131032, the script replaced a page title's spaces with underscores for some reason. Aaron Liu (talk) 15:34, 16 February 2024 (UTC)


 * @Aaron Liu This should be fixed now, sorry for the delay in responding to this, I didn't see the message when it was originally posted. Terasail [✉️] 16:10, 12 May 2024 (UTC)

Uncaught TypeError: mw.Api is not a constructor
Steps to reproduce: install script, then visit any page, add ?debug=1 in the URL, then refresh.

Fix: load the library mediawiki.api somewhere in your code. Can do this by wrapping everything in, or maybe by just adding it to your existing   statements.

Motivation: reduce JavaScript console log spam while I am debugging other scripts with this script installed.

Thanks in advance. Happy coding. – Novem Linguae (talk) 16:43, 7 May 2024 (UTC)


 * @Terasail. Ping as requested. – Novem Linguae (talk) 16:44, 7 May 2024 (UTC)
 * @Novem Linguae I have updated this aswell to hopefully stop this from happening, let me know if it is still throwing errors. Terasail [✉️] 16:02, 12 May 2024 (UTC)
 * Looks fixed to me. The console error is gone. Thanks! – Novem Linguae (talk) 17:06, 12 May 2024 (UTC)

Inoperative for a few months
For some reason this script has been broken for me for a few months, it just hangs with the progress bar looping forever. The chrome console gives me "TypeError: Cannot read properties of undefined (reading 'id') at saveResponseERT (index.php?title=User:Terasail/Edit_Request_Tool.js&action=raw&ctype=text/javascript:377:66)", if that helps. Let me know if there is more information I could provide, or if I've missed something obvious. Best, CMD (talk) 02:01, 4 July 2024 (UTC)


 * @Chipmunkdavis, On Sunday I had updated the way that the script worked but only tested on Vector22 and it looks like I missed an error that had stopped it from working on the old Vector skin for some time. I have just updated it so that it should work on the old Vector skin again. Can you test again to see if it is working for you again. If it still isn't working please let me know. Terasail [✉️] 14:23, 4 July 2024 (UTC)
 * Wow, thank you very much I did not expect this to be a priority. It works again. Best, CMD (talk) 14:33, 4 July 2024 (UTC)