Wikipedia:Bots/Requests for approval/JJMC89 bot 7


 * The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was Symbol keep vote.svg Approved

JJMC89 bot 7
Operator:

Time filed: 22:40, Monday, September 5, 2016 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): C# (Custom AWB module) Python

Source code available: Partial: AWB

Function overview: Migrate infobox coordinates parameters to Coord

Links to relevant discussions (where appropriate):
 * RfC
 * BOTREQ for Infobox park (permalink)
 * BOTREQ for Infobox park (permalink)

Edit period(s): One run per infobox

Estimated number of pages affected: Up to the number of articles transcluding each infobox (6–10 edits/min)

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: Migrate infobox coordinates parameters to Coord using a template wrapper substitution.

Discussion
Infobox park will be used for the bot trial with {{subst:Infobox coord/sandbox}} as the wrapper to convert the coordinates parameters to coords.


 * —&thinsp;JJMC89&thinsp; (T·C) 22:40, 5 September 2016 (UTC)
 * Minor comment: Should °N, °W in the edit summary be escaped or written as Coord ? Have you tested this script manually to see if the edit summary parses correctly? I trust that you'll make it work. – Jonesey95 (talk) 03:51, 6 September 2016 (UTC)
 * The edit summary will appear as . —&thinsp;JJMC89&thinsp; (T·C) 04:23, 6 September 2016 (UTC)
 * Could the bot also do another run after the first one to remove any remaining instances of the parameters (for all transclusions, not just those on pages in the tracking category)? Jc86035 (talk • contribs) Use &#123;&#123;re&#124;Jc86035&#125;&#125; to reply to me 10:28, 6 September 2016 (UTC)
 * The current code supports doing this, so subject to BAG approval, it can. —&thinsp;JJMC89&thinsp; (T·C) 15:54, 6 September 2016 (UTC)

Parameters for Infobox school below. Can the AWB module handle aliases?

Jc86035 (talk • contribs) Use &#123;&#123;re&#124;Jc86035&#125;&#125; to reply to me 16:19, 6 September 2016 (UTC)
 * Currently it will handle aliases where only one has a value. To handle cases where multiple have a value, I will need to update the code. —&thinsp;JJMC89&thinsp; (T·C) 17:31, 6 September 2016 (UTC)
 * The code has been revised to fully handle parameter aliases. Aliases must be in order: →.


 * —&thinsp;JJMC89&thinsp; (T·C) 05:34, 7 September 2016 (UTC)
 * Tried making one for Infobox station. Does the process normally go this long without any input from approvals group members?

to reply to me 13:03, 8 September 2016 (UTC) to reply to me 15:42, 9 September 2016 (UTC)
 * —Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;
 * Thanks. I think we're good on configurations until the bot task gets approval. There aren't many active BAG members, so it is common for it to take some time before getting any input. —&thinsp;JJMC89&thinsp; (T·C) 22:24, 8 September 2016 (UTC)
 * Pinging        everyone in the active section of the BAG members list, because why not. Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;

Any questions or comments? —&thinsp;JJMC89&thinsp; (T·C) 02:22, 13 September 2016 (UTC) to reply to me 03:47, 19 September 2016 (UTC)
 * Do you have any ballpark estimation to the number of edits this task will make? — xaosflux  Talk 01:27, 19 September 2016 (UTC)
 * I'd say around 100,000 to a million pages. Possibly before this task ends, the Geohack parameter syntax might be changed due to the introduction of Kartographer's  (which  might want Coord to be based on), so that would involve some more pages. Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;
 * That depends on the scope of the approval. If the task is approved to remove all the deprecated parameters, then significantly more edits will be needed. There are roughly 830k transclusions of the infoboxes currently listed at Help:Coordinates in infoboxes. Three of them have been setup to test for needing the change. If those three are representative, then about 90k of the 830k would need to be edited to convert to use coord. I don't think those three are representative, so that is probably on the low end. —&thinsp;JJMC89&thinsp; (T·C) 04:28, 19 September 2016 (UTC)
 * —&thinsp;JJMC89&thinsp; (T·C) 03:03, 27 September 2016 (UTC)

to reply to me 02:44, 24 October 2016 (UTC) to reply to me 08:08, 24 October 2016 (UTC) I have rewritten this in Python. It will now use an on-wiki JSON configuration. Each template can have its own configuration page (e.g. ) or a single page can be recycled for all templates (e.g.  ).
 * — xaosflux  Talk 16:45, 23 October 2016 (UTC)
 * The bot edited as intended: [ 60 edits] . —&thinsp;JJMC89&thinsp; (T·C) 22:32, 23 October 2016 (UTC)
 * Just a few minor things: why does the bot move the parameter to the end; and could it take into account the parameter spacing of the other infobox parameters so that the coords parameter matches them? Thanks, Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;
 * It is using  to set the parameter value. If the   is already in the template, it will update the value in place (example). In this case, any spacing is maintained. Otherwise, the   is appended to the end. In that case, it attempts to match the spacing around the   but not the  . If either of those is important, it would be easier for me to rewrite this in Python than to implement them in the module. —&thinsp;JJMC89&thinsp; (T·C) 05:40, 24 October 2016 (UTC)
 * Well, it's not strictly necessary to fix the spacing or the position, but it'd be prettier and – if we're going to affect hundreds of thousands of articles – it would probably be worth the effort. Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;

to reply to me 11:42, 2 November 2016 (UTC) to reply to me 05:30, 6 November 2016 (UTC) to reply to me 13:54, 7 November 2016 (UTC)
 * —&thinsp;JJMC89&thinsp; (T·C) 05:17, 31 October 2016 (UTC)
 * Trial restart for new codebase. — xaosflux  Talk 11:41, 31 October 2016 (UTC)
 * [ 50 edits] . There were two edits with non-ideal positioning for coords due to one of the deprecated parameters being separated from the others and one with extra spacing due to the spacing in the embedded . Configurations can be found here. —&thinsp;JJMC89&thinsp; (T·C) 03:52, 1 November 2016 (UTC)
 * Looks pretty good. Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;
 * I patched the spacing issue last night. —&thinsp;JJMC89&thinsp; (T·C) 16:37, 2 November 2016 (UTC)
 * The position for inserting replacementParameter is now before the first parameter in the ordered parametersMap that is found in . (parametersMap was previously unordered.) —&thinsp;JJMC89&thinsp; (T·C) 05:02, 6 November 2016 (UTC)
 * Would the bot automatically use new template configurations added to the list (with the list being extended-confirmed protected)? —Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;
 * The bot does not start automatically. I must run the script, specifying a configuration. —&thinsp;JJMC89&thinsp; (T·C) 20:58, 6 November 2016 (UTC)
 * (pinging, and ) Okay then. I guess we're good to go for the first two or three then? Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125;
 * I checked some of these edits to infobox park, and they looked good to me. – Jonesey95 (talk) 16:02, 7 November 2016 (UTC)

As noted, the trial finished and all the issues we've found are fixed. Jc86035 (talk) Use &#123;&#123;re&#124;Jc86035&#125;&#125; to reply to me 11:12, 11 November 2016 (UTC)


 * Task approved. — xaosflux  Talk 14:22, 11 November 2016 (UTC)
 * Due to the huge size of your potential edit pool, a ramp-up schedule is to be used to allow unexpected issues to be brought to your attention should they present:
 * 1500 edits, 24 hour hold
 * 2500 edits, 24 hour hold
 * 5000 edits, 24 hour hold
 * 5000 edits, 24 hour hold
 * open editing
 * Should minor issues be brought up that are causing page problem - address and restart the ramp up schedule above. — xaosflux  Talk 14:22, 11 November 2016 (UTC)


 * The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.